@@ -1698,7 +1698,7 @@ or refactoring an existing one.
16981698
16991699** Bad:**
17001700``` javascript
1701- const assert = require ( ' assert' ) ;
1701+ import assert from ' assert' ;
17021702
17031703describe (' MakeMomentJSGreatAgain' , () => {
17041704 it (' handles date boundaries' , () => {
@@ -1721,7 +1721,7 @@ describe('MakeMomentJSGreatAgain', () => {
17211721
17221722** Good:**
17231723``` javascript
1724- const assert = require ( ' assert' ) ;
1724+ import assert from ' assert' ;
17251725
17261726describe (' MakeMomentJSGreatAgain' , () => {
17271727 it (' handles 30-day months' , () => {
@@ -1752,11 +1752,14 @@ Promises are a built-in global type. Use them!
17521752
17531753** Bad:**
17541754``` javascript
1755- require (' request' ).get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' , (requestErr , response ) => {
1755+ import { get } from ' request' ;
1756+ import { writeFile } from ' fs' ;
1757+
1758+ get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' , (requestErr , response ) => {
17561759 if (requestErr) {
17571760 console .error (requestErr);
17581761 } else {
1759- require ( ' fs ' ). writeFile (' article.html' , response .body , (writeErr ) => {
1762+ writeFile (' article.html' , response .body , (writeErr ) => {
17601763 if (writeErr) {
17611764 console .error (writeErr);
17621765 } else {
@@ -1770,9 +1773,12 @@ require('request').get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin', (req
17701773
17711774** Good:**
17721775``` javascript
1773- require (' request-promise' ).get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' )
1776+ import { get } from ' request' ;
1777+ import { writeFile } from ' fs' ;
1778+
1779+ get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' )
17741780 .then ((response ) => {
1775- return require ( ' fs-promise ' ). writeFile (' article.html' , response);
1781+ return writeFile (' article.html' , response);
17761782 })
17771783 .then (() => {
17781784 console .log (' File written' );
@@ -1793,9 +1799,12 @@ today!
17931799
17941800** Bad:**
17951801``` javascript
1796- require (' request-promise' ).get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' )
1802+ import { get } from ' request-promise' ;
1803+ import { writeFile } from ' fs-promise' ;
1804+
1805+ get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' )
17971806 .then ((response ) => {
1798- return require ( ' fs-promise ' ). writeFile (' article.html' , response);
1807+ return writeFile (' article.html' , response);
17991808 })
18001809 .then (() => {
18011810 console .log (' File written' );
@@ -1808,10 +1817,13 @@ require('request-promise').get('https://en.wikipedia.org/wiki/Robert_Cecil_Marti
18081817
18091818** Good:**
18101819``` javascript
1820+ import { get } from ' request-promise' ;
1821+ import { writeFile } from ' fs-promise' ;
1822+
18111823async function getCleanCodeArticle () {
18121824 try {
1813- const response = await require ( ' request-promise ' ). get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' );
1814- await require ( ' fs-promise ' ). writeFile (' article.html' , response);
1825+ const response = await get (' https://en.wikipedia.org/wiki/Robert_Cecil_Martin' );
1826+ await writeFile (' article.html' , response);
18151827 console .log (' File written' );
18161828 } catch (err) {
18171829 console .error (err);
0 commit comments