Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: callstack/react-native-builder-bob
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: [email protected]
Choose a base ref
...
head repository: callstack/react-native-builder-bob
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: [email protected]
Choose a head ref
  • 5 commits
  • 13 files changed
  • 4 contributors

Commits on Jan 28, 2025

  1. feat(bob): support custom target definitions (#732)

    ### Summary
    
    This adds the `custom` target to bob. Users are able to pass arbitrary
    scripts via this target and bob will call those scripts.
    
    ### Test plan
    
    1. Configure bob in a new project
    2. Define the `custom` target
    3. Define a script that generates some files
    4. Call bob build and make sure the script was called with the right
    package manager
    
    ---------
    
    Co-authored-by: Satyajit Sahoo <[email protected]>
    atlj and satya164 authored Jan 28, 2025
    Configuration menu
    Copy the full SHA
    5b42f44 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2025

  1. chore: adding .xcode.env.local to $.gitignore (#759)

    <!-- Please provide enough information so that others can review your
    pull request. -->
    <!-- Keep pull requests small and focused on a single change. -->
    
    ### Summary
    
    <!-- What existing problem does the pull request solve? Can you solve
    the issue with a different approach? -->
    
    Adding `.xcode.env.local` to the `.gitignore`
    
    ### Test plan
    
    <!-- List the steps with which we can test this change. Provide
    screenshots if this changes anything visual. -->
    Mhp23 authored Jan 31, 2025
    Configuration menu
    Copy the full SHA
    10d4aeb View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2025

  1. chore: upgrading the Bob fallback version to v0.36.0 (#762)

    <!-- Please provide enough information so that others can review your
    pull request. -->
    <!-- Keep pull requests small and focused on a single change. -->
    
    ### Summary
    
    <!-- What existing problem does the pull request solve? Can you solve
    the issue with a different approach? -->
    
    Upgrading the builder Bob fallback version to `v0.36.0`
    
    I’ve been working on two recently created libraries, and both were
    failing to build for iOS due to duplicated symbols caused by codegen. I
    checked the Bob builder and saw that this issue was fixed in v0.35.3,
    but when creating a new library with `create-react-native-library`, it
    was resolving to v0.32.0. It seems the Bob version wasn’t resolving
    correctly and was falling back to v0.32.0. So, I upgraded the fallback
    version to the latest stable release.
    
    ### Test plan
    
    Built for iOS, and CI completed successfully.
    
    <!-- List the steps with which we can test this change. Provide
    screenshots if this changes anything visual. -->
    Mhp23 authored Feb 6, 2025
    Configuration menu
    Copy the full SHA
    cefb415 View commit details
    Browse the repository at this point in the history
  2. fix: nkdversion -> ndkVersion casing in gradle.properties (#744)

    <!-- Please provide enough information so that others can review your
    pull request. -->
    <!-- Keep pull requests small and focused on a single change. -->
    
    ### Summary
    
    I think this was a typo? Otherwise it wouldn't match with [this
    line](https://github.com/callstack/react-native-builder-bob/blob/87b0032acd66b7b14a5b358117a3d1497c59baad/packages/create-react-native-library/templates/native-common/android/build.gradle#L62)?
    
    ### Test plan
    
    –
    KiwiKilian authored Feb 6, 2025
    Configuration menu
    Copy the full SHA
    981eea1 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2025

  1. Configuration menu
    Copy the full SHA
    ec2c874 View commit details
    Browse the repository at this point in the history
Loading