feat: query nested text nodes #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Awesome! Can we add a test please? :) |
cross19xx
approved these changes
May 8, 2020
thymikee
reviewed
May 8, 2020
src/helpers/getByAPI.js
Outdated
| if (child.props.children) { | ||
| const { children } = child.props; | ||
|
|
||
| if (children instanceof Array) { |
Member
There was a problem hiding this comment.
Don't use instanceof to check for array. Use .length
thymikee
reviewed
May 8, 2020
thymikee
reviewed
May 8, 2020
src/helpers/getByAPI.js
Outdated
| if (children instanceof Array) { | ||
| children.forEach(node => { | ||
| // eslint-disable-next-line | ||
| const { Text } = require('react-native'); |
Member
There was a problem hiding this comment.
Text is retrieved from the caller, let's pass it through function parameters, instead of requiring it in yet another place.
thymikee
requested changes
May 8, 2020
Member
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
Thank you so much for this contribution! It's a good start and we can make it even better 👍
thymikee
reviewed
May 8, 2020
thymikee
reviewed
May 11, 2020
thymikee
force-pushed
the
query-text-nodes
branch
from
fd13ac4 to
74eb27c
Compare
thymikee
approved these changes
May 11, 2020
Member
|
Thanks once again! @Trancever will be happy :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support
*ByTextto match text for nestedTextcomponents.Closes #275
Test plan
Text, eg<Text/>RN Testing <Text/>Library</Text></Text>getAllByText