Release semaphores when only maxConnectionsPerHost is enabled, closed AsyncHttpClient#920

Author: slandelle

providers/netty3/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java

@@ -129,13 +129,14 @@ public ChannelManager(final AsyncHttpClientConfig config, NettyAsyncHttpProvider
         maxTotalConnectionsEnabled = config.getMaxConnections() > 0;
         maxConnectionsPerHostEnabled = config.getMaxConnectionsPerHost() > 0;
 
-        if (maxTotalConnectionsEnabled) {
+        if (maxTotalConnectionsEnabled || maxConnectionsPerHostEnabled) {
             openChannels = new CleanupChannelGroup("asyncHttpClient") {
                 @Override
                 public boolean remove(Object o) {
                     boolean removed = super.remove(o);
                     if (removed) {
-                        freeChannels.release();
+                        if (maxTotalConnectionsEnabled)
+                            freeChannels.release();
                         if (maxConnectionsPerHostEnabled) {
                             Object partitionKey = channelId2PartitionKey.remove(Channel.class.cast(o).getId());
                             if (partitionKey != null) {

providers/netty4/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java

@@ -125,13 +125,14 @@ public ChannelManager(final AsyncHttpClientConfig config, NettyAsyncHttpProvider
         maxTotalConnectionsEnabled = config.getMaxConnections() > 0;
         maxConnectionsPerHostEnabled = config.getMaxConnectionsPerHost() > 0;
 
-        if (maxTotalConnectionsEnabled) {
+        if (maxTotalConnectionsEnabled || maxConnectionsPerHostEnabled) {
             openChannels = new CleanupChannelGroup("asyncHttpClient") {
                 @Override
                 public boolean remove(Object o) {
                     boolean removed = super.remove(o);
                     if (removed) {
-                        freeChannels.release();
+                        if (maxTotalConnectionsEnabled)
+                            freeChannels.release();
                         if (maxConnectionsPerHostEnabled) {
                             Object partitionKey = channelId2PartitionKey.remove(Channel.class.cast(o));
                             if (partitionKey != null) {