fix(components): [GenericTable] Delimit regular variant height MAASENG-5415 (#186)

* fix(components): [GenericTable] removed GroupRowActions.tsx

* fix(components): [GenericTable] keep auto sizing for regular variant even if it overflows

* fix(components): [GenericTable] fixed stories, added chevrons

* fix(components): [GenericTable] linting

Author: abuyukyi101198

src/lib/components/GenericTable/GenericTable.stories.tsx

@@ -12,7 +12,6 @@ import {
 } from "@tanstack/react-table";
 
 import { GenericTable } from "@/lib/components/GenericTable/GenericTable";
-import { GroupRowActions } from "@/lib/components/GenericTable/GroupRowActions";
 
 type Machine = {
   id: number;
@@ -438,7 +437,6 @@ export const ConditionallySelectable: Story = {
         accessorKey: "id",
         header: "Actions",
         cell: ({ row }: { row: Row<Machine> }) => {
-          if (row.getIsGrouped()) return <GroupRowActions row={row} />;
           return (
             <div className="actions-cell">
               <Tooltip
@@ -501,6 +499,7 @@ export const Grouped: Story = {
     },
     filterHeaders: (header: Header<Machine, unknown>): boolean =>
       header.column.id !== "status",
+    showChevron: true,
   },
 };
 
@@ -581,6 +580,7 @@ export const GroupedSelectable: Story = {
     },
     filterHeaders: (header: Header<Machine, unknown>): boolean =>
       header.column.id !== "status",
+    showChevron: true,
   },
 };
 
@@ -633,7 +633,6 @@ export const GroupedNested: Story = {
         accessorKey: "id",
         header: "Actions",
         cell: ({ row }: { row: Row<Machine> }) => {
-          if (row.getIsGrouped()) return <GroupRowActions row={row} />;
           return (
             <div className="actions-cell">
               <Tooltip

src/lib/components/GenericTable/GenericTable.tsx

@@ -256,12 +256,11 @@ export const GenericTable = <T extends { id: number | string }>({
           const isExpanded = row.getIsExpanded();
           if (row.getIsGrouped()) {
             return (
-              <Tooltip message={isExpanded ? "Collapse" : "Expand"} position="btm-right">
-                <Icon
-                  name={
-                    isExpanded ? ICONS.chevronUp : ICONS.chevronDown
-                  }
-                />
+              <Tooltip
+                message={isExpanded ? "Collapse" : "Expand"}
+                position="btm-right"
+              >
+                <Icon name={isExpanded ? ICONS.chevronUp : ICONS.chevronDown} />
               </Tooltip>
             );
           }
@@ -365,7 +364,11 @@ export const GenericTable = <T extends { id: number | string }>({
       const willNeedScrolling = contentHeight > availableHeight;
 
       setNeedsScrolling(willNeedScrolling);
-      setMaxHeight(willNeedScrolling ? `${availableHeight}px` : "auto");
+      setMaxHeight(
+        variant === "full-height" && willNeedScrolling
+          ? `${availableHeight}px`
+          : "auto",
+      );
     };
 
     updateHeight();

src/lib/components/GenericTable/GroupRowActions/GroupRowActions.test.tsx

@@ -1,2 +1 @@
 export * from "./GenericTable";
-export * from "./GroupRowActions/GroupRowActions";