Skip to content

Memoize causes queued callbacks to jump across domains #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Memoize causes queued callbacks to jump across domains #999

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c92bc2c
Memoize will now play nicely with Nodejs domains.
owenallenaz Jan 4, 2016
64a6dd5
Adds test case
owenallenaz Jan 4, 2016
69dc7a4
Style correction
owenallenaz Jan 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Style correction
  • Loading branch information
@owenallenaz
owenallenaz committed Jan 4, 2016
commit 69dc7a4e7623bf86f751e1c7195fc0801b36199d
7 changes: 1 addition & 6 deletions test/test-async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4364,12 +4364,7 @@ exports['memoize'] = {
});

var i = setInterval(function() {
if (
d1Error === false
&& d2Error === true
&& d1Done === true
&& d2Done === false
) {
if (d1Error === false && d2Error === true && d1Done === true && d2Done === false) {
clearInterval(i);
test.equal(process.domain, null);
test.done();
Expand Down