declare FirmataSerial as 'Stream *' instead of 'Stream &'

Author: ntruchsess

Firmata.cpp

@@ -28,25 +28,25 @@ extern "C" {
 
 void FirmataClass::sendValueAsTwo7bitBytes(int value)
 {
-  FirmataSerial.write(value & B01111111); // LSB
-  FirmataSerial.write(value >> 7 & B01111111); // MSB
+  FirmataSerial->write(value & B01111111); // LSB
+  FirmataSerial->write(value >> 7 & B01111111); // MSB
 }
 
 void FirmataClass::startSysex(void)
 {
-  FirmataSerial.write(START_SYSEX);
+  FirmataSerial->write(START_SYSEX);
 }
 
 void FirmataClass::endSysex(void)
 {
-  FirmataSerial.write(END_SYSEX);
+  FirmataSerial->write(END_SYSEX);
 }
 
 //******************************************************************************
 //* Constructors
 //******************************************************************************
 
-FirmataClass::FirmataClass(Stream &s) : FirmataSerial(s)
+FirmataClass::FirmataClass()
 {
   firmwareVersionCount = 0;
   systemReset();
@@ -66,25 +66,25 @@ void FirmataClass::begin(void)
 void FirmataClass::begin(long speed)
 {
   Serial.begin(speed);
-  FirmataSerial = Serial;
+  FirmataSerial = &Serial;
   blinkVersion();
   printVersion();
   printFirmwareVersion();
 }
 
 void FirmataClass::begin(Stream &s)
 {
-  FirmataSerial = s;
+  FirmataSerial = &s;
   systemReset();
   printVersion();
   printFirmwareVersion();
 }
 
 // output the protocol version message to the serial port
 void FirmataClass::printVersion(void) {
-  FirmataSerial.write(REPORT_VERSION);
-  FirmataSerial.write(FIRMATA_MAJOR_VERSION);
-  FirmataSerial.write(FIRMATA_MINOR_VERSION);
+  FirmataSerial->write(REPORT_VERSION);
+  FirmataSerial->write(FIRMATA_MAJOR_VERSION);
+  FirmataSerial->write(FIRMATA_MINOR_VERSION);
 }
 
 void FirmataClass::blinkVersion(void)
@@ -103,9 +103,9 @@ void FirmataClass::printFirmwareVersion(void)
 
   if(firmwareVersionCount) { // make sure that the name has been set before reporting
     startSysex();
-    FirmataSerial.write(REPORT_FIRMWARE);
-    FirmataSerial.write(firmwareVersionVector[0]); // major version number
-    FirmataSerial.write(firmwareVersionVector[1]); // minor version number
+    FirmataSerial->write(REPORT_FIRMWARE);
+    FirmataSerial->write(firmwareVersionVector[0]); // major version number
+    FirmataSerial->write(firmwareVersionVector[1]); // minor version number
     for(i=2; i<firmwareVersionCount; ++i) {
       sendValueAsTwo7bitBytes(firmwareVersionVector[i]);
     }
@@ -146,7 +146,7 @@ void FirmataClass::setFirmwareNameAndVersion(const char *name, byte major, byte
 
 int FirmataClass::available(void)
 {
-  return FirmataSerial.available();
+  return FirmataSerial->available();
 }
 
 
@@ -180,7 +180,7 @@ void FirmataClass::processSysexMessage(void)
 
 void FirmataClass::processInput(void)
 {
-  int inputData = FirmataSerial.read(); // this is 'int' to handle -1 when no data
+  int inputData = FirmataSerial->read(); // this is 'int' to handle -1 when no data
   int command;
 
   // TODO make sure it handles -1 properly
@@ -272,7 +272,7 @@ void FirmataClass::processInput(void)
 void FirmataClass::sendAnalog(byte pin, int value) 
 {
   // pin can only be 0-15, so chop higher bits
-  FirmataSerial.write(ANALOG_MESSAGE | (pin & 0xF));
+  FirmataSerial->write(ANALOG_MESSAGE | (pin & 0xF));
   sendValueAsTwo7bitBytes(value);
 }
 
@@ -303,17 +303,17 @@ void FirmataClass::sendDigital(byte pin, int value)
 // send an 8-bit port in a single digital message (protocol v2)
 void FirmataClass::sendDigitalPort(byte portNumber, int portData)
 {
-  FirmataSerial.write(DIGITAL_MESSAGE | (portNumber & 0xF));
-  FirmataSerial.write((byte)portData % 128); // Tx bits 0-6
-  FirmataSerial.write(portData >> 7);  // Tx bits 7-13
+  FirmataSerial->write(DIGITAL_MESSAGE | (portNumber & 0xF));
+  FirmataSerial->write((byte)portData % 128); // Tx bits 0-6
+  FirmataSerial->write(portData >> 7);  // Tx bits 7-13
 }
 
 
 void FirmataClass::sendSysex(byte command, byte bytec, byte* bytev) 
 {
   byte i;
   startSysex();
-  FirmataSerial.write(command);
+  FirmataSerial->write(command);
   for(i=0; i<bytec; i++) {
     sendValueAsTwo7bitBytes(bytev[i]);        
   }
@@ -335,7 +335,7 @@ void FirmataClass::sendString(const char* string)
 // expose the write method
 void FirmataClass::write(byte c)
 {
-  FirmataSerial.write(c);
+  FirmataSerial->write(c);
 }
 
 

Firmata.h

@@ -87,7 +87,7 @@ extern "C" {
 class FirmataClass
 {
 public:
-    FirmataClass(Stream &s);
+    FirmataClass();
 /* Arduino constructors */
     void begin();
     void begin(long);