Proof of concept #1
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
internal/kubernetes/signer/README.md
Outdated
| @@ -0,0 +1 @@ | |||
| Copied from: https://github.com/kubernetes/kubernetes/tree/v1.18.0-beta.2/pkg/controller/certificates/signer | |||
There was a problem hiding this comment.
👍 thanks for the README here :) in future it may be worth extracting some of these stuff out into our own package, but this works!
There was a problem hiding this comment.
It's also worth noting this PR which allows configurable intermediate certs to be included as part of the Certificate: kubernetes/kubernetes#88741
wallrj
force-pushed
the
init
branch
7 times, most recently
from
7f4272b to
0b09b5b
Compare
* Watch CertificateSigningRequest resources * Ignore unapproved * Ignore unrecognised signerName values * Create a signed Certificate signed by the supplied CA file * Manifests to deploy the controller-manager * Docker based build environment. * Makefile for testing and building everything * Brief documentation and demo in a README file Signed-off-by: Richard Wall <[email protected]>
|
@munnerz Please take another quick look. There are no tests for this proof of concept, but I did add a short demo of the testing that I've been doing locally. |
|
/lgtm |
3 participants
Signs an approved CSR using a local CA key and certificate.