From e7559770d669e411e7f26c599604d3c90423bb9d Mon Sep 17 00:00:00 2001 From: austin ce Date: Wed, 24 Feb 2021 13:15:14 -0500 Subject: [PATCH 1/2] ci: correctly template github event in if condition for release --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1e865dc..572d316 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,7 +28,7 @@ jobs: - uses: coverallsapp/github-action@v1.0.1 with: github-token: ${{ secrets.github_token }} - + publish-npm: needs: build @@ -40,7 +40,7 @@ jobs: node-version: 12 registry-url: https://registry.npmjs.org/ - run: npm run release - if: github.event == 'push' + if: ${{ github.event == 'push' }} env: NPM_TOKEN: ${{secrets.NPM_TOKEN}} GITHUB_TOKEN: ${{secrets.github_token}} From fb7cc868860a8f11d1fa079a6fd039a3b0f43536 Mon Sep 17 00:00:00 2001 From: Keith Cirkel Date: Wed, 24 Feb 2021 18:21:32 +0000 Subject: [PATCH 2/2] add comment for NPM token name --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 572d316..bfaddcd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -42,5 +42,5 @@ jobs: - run: npm run release if: ${{ github.event == 'push' }} env: - NPM_TOKEN: ${{secrets.NPM_TOKEN}} + NPM_TOKEN: ${{secrets.NPM_TOKEN}} # f674......69f0 GITHUB_TOKEN: ${{secrets.github_token}}