Skip to content

fix: multiple symbols and sort fails - Cannot convert a Symbol value to a string #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2022
Merged

fix: multiple symbols and sort fails - Cannot convert a Symbol value to a string #83

merged 3 commits into from
Nov 5, 2022

Conversation

@snewcomer
Copy link
Contributor

@snewcomer snewcomer commented Feb 28, 2022

Screen Shot 2022-02-28 at 9 13 25 AM

@snewcomer snewcomer force-pushed the sn/bug-multiple branch 4 times, most recently from df9d805 to 5a03ebc Compare February 28, 2022 15:18
@snewcomer
Copy link
Contributor Author

snewcomer commented Feb 28, 2022

ha

Screen Shot 2022-02-28 at 9 00 50 AM

@snewcomer snewcomer mentioned this pull request Feb 28, 2022
Merged
@snewcomer snewcomer force-pushed the sn/bug-multiple branch 3 times, most recently from 9190a54 to 3c88fb4 Compare February 28, 2022 16:14
snewcomer
snewcomer commented Feb 28, 2022
View reviewed changes
keithamus
keithamus reviewed Nov 4, 2022
View reviewed changes
@snewcomer snewcomer requested a review from keithamus November 5, 2022 13:32
@snewcomer
Copy link
Contributor Author

snewcomer commented Nov 5, 2022 •
edited
Loading

@keithamus 👋 I reverted part of this PR and kept the tests. All seems to be good now!

keithamus
keithamus approved these changes Nov 5, 2022
View reviewed changes
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@keithamus keithamus merged commit a311421 into chaijs:main Nov 5, 2022
@snewcomer snewcomer mentioned this pull request Nov 7, 2022
Closed
@snewcomer snewcomer deleted the sn/bug-multiple branch November 9, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keithamus keithamus keithamus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@snewcomer @keithamus