ByteBufUtils shouldn't release input ByteBufs, close AsyncHttpClient#1302

Author: slandelle

netty-utils/src/main/java/org/asynchttpclient/netty/util/ByteBufUtils.java

@@ -34,23 +34,28 @@ public static String byteBuf2String(Charset charset, ByteBuf buf) throws Charact
         }
     }
 
+    public static String decodeNonOptimized(Charset charset, ByteBuf... bufs) {
+        
+        CompositeByteBuf composite = Unpooled.compositeBuffer(bufs.length);
+
+        try {
+            for (ByteBuf buf : bufs) {
+                buf.retain();
+                composite.addComponent(buf);
+            }
+
+            return composite.toString(charset);
+
+        } finally {
+            composite.release();
+        }
+    }
+    
     public static String byteBuf2String(Charset charset, ByteBuf... bufs) throws CharacterCodingException {
         if (charset.equals(UTF_8) || charset.equals(US_ASCII)) {
             return Utf8ByteBufCharsetDecoder.decodeUtf8(bufs);
         } else {
-            CompositeByteBuf composite = Unpooled.compositeBuffer(bufs.length);
-
-            try {
-                for (ByteBuf buf : bufs) {
-                    buf.retain();
-                    composite.addComponent(buf);
-                }
-
-                return composite.toString(charset);
-
-            } finally {
-                composite.release();
-            }
+            return decodeNonOptimized(charset, bufs);
         }
     }
 

netty-utils/src/main/java/org/asynchttpclient/netty/util/Utf8ByteBufCharsetDecoder.java

@@ -15,7 +15,6 @@
 
 import static java.nio.charset.StandardCharsets.UTF_8;
 import io.netty.buffer.ByteBuf;
-import io.netty.buffer.Unpooled;
 
 import java.nio.ByteBuffer;
 import java.nio.CharBuffer;
@@ -194,12 +193,7 @@ public String decode(ByteBuf... bufs) throws CharacterCodingException {
         }
 
         if (direct) {
-            ByteBuf wrappedBuffer = Unpooled.wrappedBuffer(bufs);
-            try {
-                return wrappedBuffer.toString(UTF_8);
-            } finally {
-                wrappedBuffer.release();
-            }
+            return ByteBufUtils.decodeNonOptimized(UTF_8, bufs);
 
         } else {
             ByteBuffer[] nioBuffers = new ByteBuffer[totalNioBuffers];