Fixes order see BT#9287

Author: jmontoyaa

main/gradebook/lib/fe/flatviewtable.class.php

@@ -544,30 +544,22 @@ public function get_table_data($from = 1, $per_page = null, $column = null, $dir
         // retrieve sorting type
 
         if ($is_western_name_order) {
-            //$users_sorting = ($this->column == 0 ? FlatViewDataGenerator :: FVDG_SORT_FIRSTNAME : FlatViewDataGenerator :: FVDG_SORT_LASTNAME);
-            $users_sorting = FlatViewDataGenerator :: FVDG_SORT_FIRSTNAME;
-
+            $users_sorting = ($this->column == 0 ? FlatViewDataGenerator :: FVDG_SORT_FIRSTNAME : FlatViewDataGenerator :: FVDG_SORT_LASTNAME);
         } else {
-            //$users_sorting = ($this->column == 0 ? FlatViewDataGenerator :: FVDG_SORT_LASTNAME : FlatViewDataGenerator :: FVDG_SORT_FIRSTNAME);
-            $users_sorting = FlatViewDataGenerator :: FVDG_SORT_LASTNAME;
+            $users_sorting = ($this->column == 0 ? FlatViewDataGenerator :: FVDG_SORT_LASTNAME : FlatViewDataGenerator :: FVDG_SORT_FIRSTNAME);
         }
 
         if ($this->direction == 'DESC') {
             $users_sorting |= FlatViewDataGenerator :: FVDG_SORT_DESC;
         } else {
             $users_sorting |= FlatViewDataGenerator :: FVDG_SORT_ASC;
         }
-        // step 1: generate columns: evaluations and links
 
+        // step 1: generate columns: evaluations and links
         $header_names = $this->datagen->get_header_names($this->offset, $selectlimit);
 
-        if ($is_western_name_order) {
-            $this->set_header(0, $header_names[1]);
-            $this->set_header(1, $header_names[0]);
-        } else {
-            $this->set_header(0, $header_names[0]);
-            $this->set_header(1, $header_names[1]);
-        }
+        $this->set_header(0, $header_names[0]);
+        $this->set_header(1, $header_names[1]);
 
         $column = 2;
         while ($column < count($header_names)) {
@@ -588,14 +580,13 @@ public function get_table_data($from = 1, $per_page = null, $column = null, $dir
             $table_row = array();
             $count = 0;
             $user_id = $user_row[$count++];
-            $lastname = $user_row[$count++];
-            $firstname = $user_row[$count++];
+            $userInfo = api_get_user_info($user_id);
             if ($is_western_name_order) {
-                $table_row[] = $this->build_name_link($user_id, $firstname);
-                $table_row[] = $this->build_name_link($user_id, $lastname);
+                $table_row[] = $this->build_name_link($user_id, $userInfo['firstname']);
+                $table_row[] = $this->build_name_link($user_id, $userInfo['lastname']);
             } else {
-                $table_row[] = $this->build_name_link($user_id, $lastname);
-                $table_row[] = $this->build_name_link($user_id, $firstname);
+                $table_row[] = $this->build_name_link($user_id, $userInfo['lastname']);
+                $table_row[] = $this->build_name_link($user_id, $userInfo['firstname']);
             }
             while ($count < count($user_row)) {
                 $table_row[] = $user_row[$count++];

main/gradebook/lib/flatview_data_generator.class.php

@@ -87,6 +87,7 @@ public function get_header_names($items_start = 0, $items_count = null, $show_de
         if (isset($this->params['show_official_code']) && $this->params['show_official_code']) {
             $headers[] = get_lang('OfficialCode');
         }
+
         if (isset($this->params['join_firstname_lastname']) && $this->params['join_firstname_lastname']) {
             if (api_is_western_name_order()) {
                 $headers[] = get_lang('FirstnameAndLastname');
@@ -167,7 +168,7 @@ public function get_header_names($items_start = 0, $items_count = null, $show_de
                 $add_weight = " $sub_cat_weight %";
                 $headers[] = Display::url(
                         $sub_cat->get_name(),
-                        api_get_self().'?selectcat='.$sub_cat->get_id()
+                        api_get_self().'?selectcat='.$sub_cat->get_id().'&'.api_get_cidreq()
                     ).$add_weight;
             }
         } else {
@@ -199,7 +200,6 @@ public function get_header_names($items_start = 0, $items_count = null, $show_de
         }
 
         $headers[] = api_strtoupper(get_lang('GradebookQualificationTotal'));
-
         return $headers;
     }