Skip to content

Commit 585d1cd

Browse files
Use COPY for best practices (matthewfeickert#4)
COPY is considered best practice over using ADD unless ADD's tar and remote URL capabilities are needed. c.f. - https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy - https://stackoverflow.com/a/24958548/8931942 Thanks to Dan Guest for a conversation about this that proved insightful
1 parent 8bf0f98 commit 585d1cd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ RUN apt-get -qq -y update && \
4545
apt-get -y autoremove && \
4646
rm -rf /var/lib/apt-get/lists/*
4747

48-
ADD install_python.sh install_python.sh
48+
COPY install_python.sh install_python.sh
4949
RUN bash install_python.sh ${PYTHON_VERSION_TAG} ${LINK_PYTHON_TO_PYTHON3} && \
5050
rm -r install_python.sh Python-${PYTHON_VERSION_TAG}
5151

0 commit comments

Comments
 (0)