Skip to content

Add support for hiding axis when a dataset visibility is toggled #5885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 18, 2018
Merged

Add support for hiding axis when a dataset visibility is toggled #5885

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a202f39
Add support for hiding axis when a dataset visibility is toggled
Dec 4, 2018
eea4419
Reduce code complexity
Dec 4, 2018
cdb27b5
Handle multiple datasets against one axis when hiding axis
Dec 6, 2018
99feb7a
Coderev
Dec 7, 2018
9cb217b
Update scale.fit()
Dec 8, 2018
e3181a9
Coderev, add tests
Dec 10, 2018
65c9f57
Coderev - Tests
Dec 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Coderev - Tests
  • Loading branch information
Dave Salomon committed Dec 15, 2018
commit 65c9f57b1a6ee6564cc5ef21d90d1ab88c385dc6
8 changes: 6 additions & 2 deletions test/specs/core.scale.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,8 @@ describe('Core.scale', function() {
scale.ctx = window.createMockContext();
chart.draw();

expect(scale.ctx.getCalls().length > 0).toBe(true);
expect(scale.ctx.getCalls().length).toBeGreaterThan(0);
expect(scale.height).toBeGreaterThan(0);
});

it('should not draw the axes if no associated datasets are visible', function() {
Expand Down Expand Up @@ -217,6 +218,7 @@ describe('Core.scale', function() {
chart.draw();

expect(scale.ctx.getCalls().length).toBe(0);
expect(scale.height).toBe(0);
});
});

Expand Down Expand Up @@ -250,7 +252,8 @@ describe('Core.scale', function() {
scale.ctx = window.createMockContext();
chart.draw();

expect(scale.ctx.getCalls().length > 0).toBe(true);
expect(scale.ctx.getCalls().length).toBeGreaterThan(0);
expect(scale.width).toBeGreaterThan(0);
});

it('should not draw the axes if no associated datasets are visible', function() {
Expand Down Expand Up @@ -279,6 +282,7 @@ describe('Core.scale', function() {
chart.draw();

expect(scale.ctx.getCalls().length).toBe(0);
expect(scale.width).toBe(0);
});
});
});
Expand Down