Skip to content

Commit fa09aa2

Browse files
committed
tests: Use proper timeouts in gitrepository and helmrepository tests
I assume using "interval" for timeouts was an accident and "timeout" was actually meant to be used. This also fixes flakiness of tests. Signed-off-by: Alexander Block <[email protected]>
1 parent 7c8b175 commit fa09aa2

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

controllers/gitrepository_controller_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ func TestGitRepositoryReconciler_reconcileSource_authStrategy(t *testing.T) {
434434
},
435435
Spec: sourcev1.GitRepositorySpec{
436436
Interval: metav1.Duration{Duration: interval},
437-
Timeout: &metav1.Duration{Duration: interval},
437+
Timeout: &metav1.Duration{Duration: timeout},
438438
},
439439
}
440440

@@ -653,7 +653,7 @@ func TestGitRepositoryReconciler_reconcileSource_checkoutStrategy(t *testing.T)
653653
},
654654
Spec: sourcev1.GitRepositorySpec{
655655
Interval: metav1.Duration{Duration: interval},
656-
Timeout: &metav1.Duration{Duration: interval},
656+
Timeout: &metav1.Duration{Duration: timeout},
657657
URL: server.HTTPAddress() + repoPath,
658658
Reference: tt.reference,
659659
},
@@ -1517,7 +1517,7 @@ func TestGitRepositoryReconciler_ConditionsUpdate(t *testing.T) {
15171517
URL: server.HTTPAddress() + repoPath,
15181518
GitImplementation: sourcev1.GoGitImplementation,
15191519
Interval: metav1.Duration{Duration: interval},
1520-
Timeout: &metav1.Duration{Duration: interval},
1520+
Timeout: &metav1.Duration{Duration: timeout},
15211521
},
15221522
}
15231523

controllers/helmrepository_controller_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ func TestHelmRepositoryReconciler_reconcileSource(t *testing.T) {
440440
},
441441
Spec: sourcev1.HelmRepositorySpec{
442442
Interval: metav1.Duration{Duration: interval},
443-
Timeout: &metav1.Duration{Duration: interval},
443+
Timeout: &metav1.Duration{Duration: timeout},
444444
},
445445
}
446446

0 commit comments

Comments
 (0)