Fix bug in DNS check (fixes issue tpyo#22)

tpyo · tpyo · commit 57d9fa8dd435 · 2013-06-11T18:31:24.000+02:00
diff --git a/S3.php b/S3.php
@@ -2217,7 +2217,7 @@ private function __responseWriteCallback(&$curl, &$data)
 	*/
 	private function __dnsBucketName($bucket)
 	{
-		if (strlen($bucket) > 63 || !preg_match("/[^a-z0-9\.-]/", $bucket)) return false;
+		if (strlen($bucket) > 63 || preg_match("/[^a-z0-9\.-]/", $bucket) > 0) return false;
 		if (strstr($bucket, '-.') !== false) return false;
 		if (strstr($bucket, '..') !== false) return false;
 		if (!preg_match("/^[0-9a-z]/", $bucket)) return false;

Original file line number	Diff line number	Diff line change
`@@ -2217,7 +2217,7 @@ private function __responseWriteCallback(&$curl, &$data)`
`2217`	`2217`	`*/`
`2218`	`2218`	`private function __dnsBucketName($bucket)`
`2219`	`2219`	`{`
`2220`		`- if (strlen($bucket) > 63 \|\| !preg_match("/[^a-z0-9\.-]/", $bucket)) return false;`
	`2220`	`+ if (strlen($bucket) > 63 \|\| preg_match("/[^a-z0-9\.-]/", $bucket) > 0) return false;`
`2221`	`2221`	`if (strstr($bucket, '-.') !== false) return false;`
`2222`	`2222`	`if (strstr($bucket, '..') !== false) return false;`
`2223`	`2223`	`if (!preg_match("/^[0-9a-z]/", $bucket)) return false;`