Skip to content

Feature/fix datestamps #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 11, 2015
Merged

Feature/fix datestamps #113

merged 4 commits into from
Jan 11, 2015

Conversation

unguiculus
Copy link
Contributor

Fixes #112.

@chewiebug
Copy link
Owner

Hi Reinhard,

Thank you for this pull request! Am I correct in assuming, that you will
need a release (not only a SNAPSHOT version) including your feature soon
after I'll have merged it?

Kind regards,
Jörg

@unguiculus
Copy link
Contributor Author

Yes, that'd be great.

Thanks,
Reinhard

@chewiebug chewiebug added this to the 1.34.1 milestone Nov 16, 2014
@chewiebug
Copy link
Owner

Hi Reinhard,

I have assigned this pull request to 1.34.1, which I plan to release during December.

Best regards,
Jörg

chewiebug
chewiebug reviewed Dec 11, 2014
View reviewed changes
pom.xml
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a property "maven.compiler.source" and "...target" in the properties section. Could you please either delete those properties or remove the entries here and update the properties in the properties section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the properties. I don't see much use in these properties in this case. I wasn't even aware that it can be configured like this.

@chewiebug
Copy link
Owner

I obviously haven't gotten around to merge this until end of December. I have moved the target date of the release to end of January. Maybe, I'll be able to merge it earlier.

@chewiebug
Copy link
Owner

...and thanks for the updates to the pull request!

@chewiebug chewiebug merged commit 289614e into chewiebug:master Jan 11, 2015
@chewiebug chewiebug self-assigned this Jan 11, 2015
@unguiculus unguiculus deleted the feature/fix-datestamps branch April 3, 2016 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chewiebug chewiebug

Labels
None yet
Projects
None yet
Milestone
1.34.1
Development

Successfully merging this pull request may close these issues.
2 participants
@unguiculus @chewiebug