Feature : isMimeType(str) #760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nicolas, I guess when you write |
profnandaa
reviewed
Dec 5, 2017
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
LGTM.
Just one thing, update the README.
Contributor
Author
|
@profnandaa Yes, I meant |
profnandaa
approved these changes
Dec 5, 2017
Ilshidur
changed the title
Collaborator
|
Thanks for the PR 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refers to : #758
This PR features the following proposition :
isMimeType(str).It checks if the passed string matches to a correct MIME type format.
e.g. :
isMimeType('application/json')checksisMimeType('application\json')DOES NOT checkisMimeType('application/json/text')DOES NOT checkisMimeType('')DOES NOT checkisMimeType('json')DOES NOT checkThe reason this function does not match to exact MIME types listed by the IANA is because of lightness purposes : it would require to include all these MIME types in this library, which would weigh it significantly. This kind of effort maybe is not worth for the use that this function has in this entire library.
This function should check against all simple cases, but I'm not sure that it handles every exceptions and other "special" MIME type rules.
Waiting for someone's approval :-)
PS : This is the first PR of this kind that I submit. I'm really open to suggestions/corrections !