vendor: bump cobra to v1.1.1 #391
Conversation
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
twpayne
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
rolinh
left a comment
rolinh
left a comment
There was a problem hiding this comment.
I think this won't be enough as our go.mod still points to gopkg.in/yaml.v2 v2.3.0 (ie the version with the unintended breaking change that cobra v1.1.1 reverted). Please, also downgrade the yaml to gopkg.in/yaml.v2 v2.2.8.
Might need to use replace directive to enforce v2.2.8 as well. Thinking about it, I noticed that cilium is using v2.3.0, is there anything to worry about? /cc @rolinh @aanm |
twpayne
force-pushed
the
pr/twpayne/bump-cobra
branch
from
9ca542f to
78c1b60
Compare
gopkg.in/yaml.v2 version 2.3.0 changes the default line wrapping from 80 characters to none. This potentially breaks Kubernetes and Helm. See spf13/cobra#1259 for discussion. Signed-off-by: Tom Payne <[email protected]>
Signed-off-by: Tom Payne <[email protected]>
twpayne
force-pushed
the
pr/twpayne/bump-cobra
branch
from
78c1b60 to
1ae702e
Compare
|
Thanks for the feedback, PR updated to pin |
maintainer-s-little-helper
bot
added
the
ready-to-merge
sayboras
left a comment
sayboras
left a comment
There was a problem hiding this comment.
LGTM 💯
Seems like I have permission in hubble as well, I thought it's only cilium repo :)
cobra 1.1.0 inadvertently included a breaking YAML change affecting
kubectl and helm. See spf13/cobra#1259 for
details.
Signed-off-by: Tom Payne [email protected]