Remove unnecessary Babel presets#130
Closed
toinevk wants to merge 2 commits into
Closed
Conversation
As noted by Ben these presets are unnecessary as meteor provides them by default. These add unnecessary time to the build.
Owner
|
Hey @toinevk, good catch. I haven't tested on my end, but does the app start up okay after removing these? If I recall, when we added the Lodash plugin, I was getting a ton of errors without specifying the |
Contributor
Author
|
Yes, no issues on my end, I used a fresh install of pup so your mileage might vary where lodash is used more heavily. I suspect that with Meteor updating to Babel 7 the missing plugin has been included. |
Owner
|
Merged as part of 1.5.0 release. Closing this out. Thanks @toinevk :) |
cleverbeagle
pushed a commit
that referenced
this pull request
Apr 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted by Ben in meteor/meteor#9571 (comment) & meteor/meteor#9469 (comment) these presets are unnecessary because Meteor already provides them. They add unnecessary additional build time and the recommended approach is to use plugins only. The requests aligns pup with Ben's recommended approach.