Remove /error route

This was just used in tests to ensure error reporting worked, but
external callers hit it sometimes, leading to noise in Sentry.

Author: tobias

src/clojars/web.clj

@@ -84,7 +84,6 @@
      (verify/routes db event-emitter)
      (token/routes db)
      (api/routes db stats)
-     (GET "/error" _ (throw (Exception. "What!? You really want an error?")))
      (PUT "*" _ {:status 405 :headers {} :body "Did you mean to use /repo?"})
      (ANY "*" _
           (try-account

test/clojars/integration/web_test.clj

@@ -4,6 +4,7 @@
    [clojars.errors :as errors]
    [clojars.log :as log]
    [clojars.test-helper :as help]
+   [clojars.web.dashboard :as dashboard]
    [clojure.test :refer [deftest is use-fixtures]]
    [kerodon.core :refer [fill-in follow-redirect follow press
                          session visit within]]
@@ -16,24 +17,22 @@
   help/run-test-app)
 
 (deftest server-errors-display-error-page
-  (with-out-str (-> (session (help/app))
-                    (visit "/error")
-                    (within [:div.small-section :> :h1]
-                      (has (text? "Oops!"))))))
-
-(deftest error-page-includes-error-id
-  (with-redefs [log/trace-id (constantly #uuid "8f3788f5-9001-444d-8c57-049ba685cea8")]
+  (with-redefs [dashboard/index-page (fn [& _] (throw (Exception. "BOOM!")))
+                log/trace-id (constantly #uuid "8f3788f5-9001-444d-8c57-049ba685cea8")]
     (with-out-str (-> (session (help/app))
-                      (visit "/error")
+                      (visit "/")
+                      (within [:div.small-section :> :h1]
+                        (has (text? "Oops!")))
                       (within [:div.small-section :> :pre.error-id]
                         (has (text? "error-id:\"8f3788f5-9001-444d-8c57-049ba685cea8\"")))))))
 
 (deftest server-errors-log-caught-exceptions
   (let [err (atom nil)]
-    (with-redefs [errors/report-error (fn [_r e & _] (reset! err e))]
+    (with-redefs [dashboard/index-page (fn [& _] (throw (Exception. "BOOM!")))
+                  errors/report-error (fn [_r e & _] (reset! err e))]
       (-> (session (help/app))
-          (visit "/error"))
-      (is (re-find #"You really want an error" (.getMessage @err))))))
+          (visit "/"))
+      (is (re-find #"BOOM" (.getMessage @err))))))
 
 (deftest browse-page-renders-multiple-pages
   (help/add-verified-group "test-user" "tester")