Upgrade clj-kondo

This also enables (and fixes found issues from) some of the newer
linters.

Author: tobias

.clj-kondo/config.edn

@@ -3,5 +3,23 @@
   clojure.java.jdbc/with-db-transaction clojure.core/let}
 
  :linters
- {:unresolved-symbol
+ {:consistent-alias
+  {:aliases {clojure.string str
+
+             honey.sql hsql
+
+             next.jdbc            jdbc
+             next.jdbc.prepare    jdbc.prepare
+             next.jdbc.result-set jdbc.result-set
+             next.jdbc.sql        sql
+             next.jdbc.types      jdbc.types}}
+
+  ;; use false?/true? instead of = false/true
+  :equals-false {:level :warning}
+  :equals-true  {:level :warning}
+
+  ;; warn if assoc-in/get-in/update-in are used with a single key
+  :single-key-in {:level :warning}
+
+  :unresolved-symbol
   {:exclude [(clojure.test/is [match?])]}}}

.gitignore

@@ -24,6 +24,7 @@ pom.xml
 /.nrepl-port
 /local-resources
 
-.clj-kondo/.cache
+.clj-kondo/*
+!.clj-kondo/config.edn
 bin/.cache
 .cpcache

bin/clj-kondo

@@ -3,7 +3,7 @@
 
 set -euo pipefail
 
-CLJ_KONDO_VERSION="2023.09.07"
+CLJ_KONDO_VERSION="2023.10.20"
 ROOT=$(cd "$(dirname "${BASH_SOURCE[0]}")/../" && pwd)
 
 function ensure_clj_kondo() {

src/clojars/auth.clj

@@ -70,7 +70,7 @@
                                  form-config
                                  (::friend/auth-config request))
                #'workflows/interactive-login-redirect)
-           (update-in request [::friend/auth-config] merge form-config)))))))
+           (update request ::friend/auth-config merge form-config)))))))
 
 (defn parse-authorization-header
   "Parses a Basic auth header into username and password."

src/clojars/http_utils.clj

@@ -10,7 +10,7 @@
   (fn [req]
     (let [response (handler req)]
       (if (= 200 (:status response))
-        (update-in response [:headers] assoc "Access-Control-Allow-Origin" "*")
+        (update response :headers assoc "Access-Control-Allow-Origin" "*")
         response))))
 
 (defn https-request? [req]

src/clojars/routes/api.clj

@@ -16,12 +16,12 @@
         (assoc
          :recent_versions (db/recent-versions db group-id artifact-id)
          :downloads (stats/download-count stats group-id artifact-id))
-        (update-in [:recent_versions]
-                   (fn [versions]
-                     (map (fn [version]
-                            (assoc version
-                                   :downloads (stats/download-count stats group-id artifact-id (:version version))))
-                          versions)))
+        (update :recent_versions
+                (fn [versions]
+                  (map (fn [version]
+                         (assoc version
+                                :downloads (stats/download-count stats group-id artifact-id (:version version))))
+                       versions)))
         response)
     (not-found nil)))
 

test/clojars/unit/verification_test.clj

@@ -16,16 +16,16 @@
   help/with-clean-database)
 
 (deftest test-group+domain-correspond?
-  (are [exp group domain]
-       (= exp (nut/group+domain-correspond? group domain))
-    true  "com.foo"     "foo.com"
-    true  "com.foo.bar" "foo.com"
-    false "com.foo"     "foo.org"
-    false "com.foo.bar" "foo.org"
-    false "foo"         "foo"
-    false "foo."        ".foo"
-    false ""            ""
-    false nil           nil))
+  (are [pred group domain]
+       (pred (nut/group+domain-correspond? group domain))
+    true?  "com.foo"     "foo.com"
+    true?  "com.foo.bar" "foo.com"
+    false? "com.foo"     "foo.org"
+    false? "com.foo.bar" "foo.org"
+    false? "foo"         "foo"
+    false? "foo."        ".foo"
+    false? ""            ""
+    false? nil           nil))
 
 (deftest verify-group-by-TXT-with-invalid-domain
   (are [given] (= "The domain name is not a valid domain name."