Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: clojure-emacs/clj-suitable
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: clojure-emacs/clj-suitable
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fix-cljs-completion-again
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Feb 7, 2020

  1. Handle the user namespace for doc completions 

    It seems like compliment is passing the 'user namespace to the doc function by
default if the namespace is missing. This patch makes so that we check in both
cljs.user and cljs.core (in this order) if that is the case.
We check in cljs.core as well because that is were the doc for built-ins lives,
rather than in cljs.user.
    @arichiardi
    arichiardi committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    73d7225 View commit details
    Browse the repository at this point in the history

  2. Make sure we return nil in macro-meta if things are missing. 

    We always want to return nil because the main
suitable.compliment.sources.cljs/doc function relies on that for trying
alternatives.
    @arichiardi
    arichiardi committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    29515f6 View commit details
    Browse the repository at this point in the history
Loading