Skip to content

Commit 3dd3153

Browse files
authored
chore: Drop google-style and use our own rubocop config (#87)
Signed-off-by: Daniel Azuma <[email protected]>
1 parent edaeb64 commit 3dd3153

28 files changed

+1006
-653
lines changed

.rubocop.yml

Lines changed: 346 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,357 @@
1-
inherit_gem:
2-
google-style: google-style.yml
1+
AllCops:
2+
NewCops: disable
3+
SuggestExtensions: false
4+
TargetRubyVersion: 2.7
35

6+
Gemspec/AddRuntimeDependency:
7+
Enabled: true
8+
Gemspec/AttributeAssignment:
9+
Enabled: true
10+
Gemspec/DeprecatedAttributeAssignment:
11+
Enabled: true
12+
Gemspec/DevelopmentDependencies:
13+
Enabled: true
14+
Gemspec/RequireMFA:
15+
Enabled: false
16+
17+
Layout/EmptyLineAfterGuardClause:
18+
Enabled: false
19+
Layout/EmptyLinesAfterModuleInclusion:
20+
Enabled: true
21+
Layout/HashAlignment:
22+
Enabled: false
23+
Layout/LineContinuationLeadingSpace:
24+
Enabled: true
25+
Layout/LineContinuationSpacing:
26+
Enabled: true
27+
Layout/LineEndStringConcatenationIndentation:
28+
Enabled: true
29+
Layout/LineLength:
30+
Max: 120
31+
Layout/SpaceBeforeBrackets:
32+
Enabled: true
33+
Layout/SpaceInsideHashLiteralBraces:
34+
Enabled: false
35+
36+
37+
Lint/AmbiguousAssignment:
38+
Enabled: true
39+
Lint/AmbiguousOperatorPrecedence:
40+
Enabled: true
41+
Lint/AmbiguousRange:
42+
Enabled: true
43+
Lint/ArrayLiteralInRegexp:
44+
Enabled: true
45+
Lint/ConstantOverwrittenInRescue:
46+
Enabled: true
47+
Lint/ConstantReassignment:
48+
Enabled: true
49+
Lint/CopDirectiveSyntax:
50+
Enabled: true
51+
Lint/DeprecatedConstants:
52+
Enabled: true
53+
Lint/DuplicateBranch:
54+
Enabled: true
55+
Lint/DuplicateMagicComment:
56+
Enabled: true
57+
Lint/DuplicateMatchPattern:
58+
Enabled: true
59+
Lint/DuplicateRegexpCharacterClassElement:
60+
Enabled: true
61+
Lint/DuplicateSetElement:
62+
Enabled: true
63+
Lint/EmptyBlock:
64+
Enabled: true
65+
Lint/EmptyClass:
66+
AllowComments: true
67+
Enabled: true
68+
Lint/EmptyInPattern:
69+
Enabled: true
70+
Lint/HashNewWithKeywordArgumentsAsDefault:
71+
Enabled: true
72+
Lint/IncompatibleIoSelectWithFiberScheduler:
73+
Enabled: true
74+
Lint/ItWithoutArgumentsInBlock:
75+
Enabled: true
76+
Lint/LambdaWithoutLiteralBlock:
77+
Enabled: true
78+
Lint/LiteralAssignmentInCondition:
79+
Enabled: true
80+
Lint/MixedCaseRange:
81+
Enabled: true
82+
Lint/NonAtomicFileOperation:
83+
Enabled: true
84+
Lint/NoReturnInBeginEndBlocks:
85+
Enabled: true
86+
Lint/NumberedParameterAssignment:
87+
Enabled: true
88+
Lint/NumericOperationWithConstantResult:
89+
Enabled: true
90+
Lint/OrAssignmentToConstant:
91+
Enabled: true
92+
Lint/RedundantDirGlobSort:
93+
Enabled: true
94+
Lint/RedundantRegexpQuantifiers:
95+
Enabled: true
96+
Lint/RedundantTypeConversion:
97+
Enabled: true
98+
Lint/RefinementImportMethods:
99+
Enabled: true
100+
Lint/RequireRangeParentheses:
101+
Enabled: true
102+
Lint/RequireRelativeSelfPath:
103+
Enabled: true
104+
Lint/SharedMutableDefault:
105+
Enabled: true
106+
Lint/SuppressedExceptionInNumberConversion:
107+
Enabled: true
108+
Lint/SymbolConversion:
109+
Enabled: true
110+
Lint/ToEnumArguments:
111+
Enabled: true
112+
Lint/TripleQuotes:
113+
Enabled: true
114+
Lint/UnescapedBracketInRegexp:
115+
Enabled: true
116+
Lint/UnexpectedBlockArity:
117+
Enabled: true
118+
Lint/UnmodifiedReduceAccumulator:
119+
Enabled: true
4120
Lint/UnusedMethodArgument:
5121
Exclude:
6122
- "lib/cloud_events/format.rb"
123+
Lint/UselessConstantScoping:
124+
Enabled: true
125+
Lint/UselessDefaultValueArgument:
126+
Enabled: true
127+
Lint/UselessDefined:
128+
Enabled: true
129+
Lint/UselessNumericOperation:
130+
Enabled: true
131+
Lint/UselessOr:
132+
Enabled: true
133+
Lint/UselessRescue:
134+
Enabled: true
135+
Lint/UselessRuby2Keywords:
136+
Enabled: true
137+
138+
Metrics/AbcSize:
139+
Max: 30
7140
Metrics/BlockLength:
8141
Exclude:
9142
- "test/**/test_*.rb"
10143
Metrics/ClassLength:
11144
Max: 300
145+
Metrics/CollectionLiteralLength:
146+
Enabled: true
147+
Metrics/CyclomaticComplexity:
148+
Max: 12
149+
Metrics/MethodLength:
150+
Max: 25
12151
Metrics/ModuleLength:
13152
Max: 300
14-
Naming/FileName:
15-
Exclude:
16-
- "examples/*/Gemfile"
17-
- ".toys/**/*.rb"
153+
Metrics/ParameterLists:
154+
Enabled: false
155+
Metrics/PerceivedComplexity:
156+
Max: 12
157+
158+
Naming/BlockForwarding:
159+
Enabled: true
160+
Naming/PredicateMethod:
161+
Enabled: true
162+
163+
Security/CompoundHash:
164+
Enabled: true
165+
Security/IoMethods:
166+
Enabled: true
167+
168+
Style/AccessorGrouping:
169+
Enabled: false
170+
Style/AmbiguousEndlessMethodDefinition:
171+
Enabled: true
172+
Style/ArgumentsForwarding:
173+
Enabled: true
174+
Style/ArrayIntersect:
175+
Enabled: true
176+
Style/ArrayIntersectWithSingleElement:
177+
Enabled: true
178+
Style/BisectedAttrAccessor:
179+
Enabled: false
180+
Style/BitwisePredicate:
181+
Enabled: true
182+
Style/CaseEquality:
183+
Enabled: false
184+
Style/CollectionCompact:
185+
Enabled: true
186+
Style/CollectionQuerying:
187+
Enabled: true
188+
Style/CombinableDefined:
189+
Enabled: true
190+
Style/ComparableBetween:
191+
Enabled: false
192+
Style/ComparableClamp:
193+
Enabled: true
194+
Style/ConcatArrayLiterals:
195+
Enabled: true
196+
Style/DataInheritance:
197+
Enabled: true
198+
Style/DigChain:
199+
Enabled: true
200+
Style/DirEmpty:
201+
Enabled: true
202+
Style/DocumentDynamicEvalDefinition:
203+
Enabled: true
204+
Style/DocumentationMethod:
205+
Enabled: false
206+
Style/EmptyHeredoc:
207+
Enabled: true
208+
Style/EmptyStringInsideInterpolation:
209+
Enabled: true
210+
Style/EndlessMethod:
211+
Enabled: true
212+
Style/EnvHome:
213+
Enabled: true
214+
Style/ExactRegexpMatch:
215+
Enabled: true
216+
Style/FetchEnvVar:
217+
Enabled: true
218+
Style/FileEmpty:
219+
Enabled: true
220+
Style/FileNull:
221+
Enabled: true
222+
Style/FileRead:
223+
Enabled: true
224+
Style/FileTouch:
225+
Enabled: true
226+
Style/FileWrite:
227+
Enabled: true
228+
Style/GuardClause:
229+
Enabled: false
230+
Style/HashConversion:
231+
Enabled: true
232+
Style/HashExcept:
233+
Enabled: true
234+
Style/HashFetchChain:
235+
Enabled: true
236+
Style/HashSlice:
237+
Enabled: true
238+
Style/IfUnlessModifier:
239+
Enabled: false
240+
Style/IfWithBooleanLiteralBranches:
241+
Enabled: true
242+
Style/InPatternThen:
243+
Enabled: true
244+
Style/ItAssignment:
245+
Enabled: true
246+
Style/ItBlockParameter:
247+
Enabled: true
248+
Style/KeywordArgumentsMerging:
249+
Enabled: true
250+
Style/MagicCommentFormat:
251+
Enabled: true
252+
Style/MapCompactWithConditionalBlock:
253+
Enabled: true
254+
Style/MapIntoArray:
255+
Enabled: true
256+
Style/MapToHash:
257+
Enabled: true
258+
Style/MapToSet:
259+
Enabled: true
260+
Style/MethodCallWithArgsParentheses:
261+
Enabled: true
262+
Style/MinMaxComparison:
263+
Enabled: true
264+
Style/MultilineInPatternThen:
265+
Enabled: true
266+
Style/NegatedIfElseCondition:
267+
Enabled: true
268+
Style/Next:
269+
Enabled: false
270+
Style/NestedFileDirname:
271+
Enabled: true
272+
Style/NilLambda:
273+
Enabled: true
274+
Style/NumberedParameters:
275+
Enabled: true
276+
Style/NumberedParametersLimit:
277+
Enabled: true
278+
Style/ObjectThen:
279+
Enabled: true
280+
Style/OpenStructUse:
281+
Enabled: true
282+
Style/OperatorMethodCall:
283+
Enabled: true
284+
Style/OptionalBooleanParameter:
285+
Enabled: false
286+
Style/QuotedSymbols:
287+
Enabled: true
288+
Style/RedundantArgument:
289+
Enabled: true
290+
Style/RedundantArrayConstructor:
291+
Enabled: true
292+
Style/RedundantArrayFlatten:
293+
Enabled: true
294+
Style/RedundantConstantBase:
295+
Enabled: false
296+
Style/RedundantCurrentDirectoryInPath:
297+
Enabled: true
298+
Style/RedundantDoubleSplatHashBraces:
299+
Enabled: true
300+
Style/RedundantEach:
301+
Enabled: true
302+
Style/RedundantFilterChain:
303+
Enabled: true
304+
Style/RedundantFormat:
305+
Enabled: true
306+
Style/RedundantHeredocDelimiterQuotes:
307+
Enabled: true
308+
Style/RedundantInitialize:
309+
Enabled: true
310+
Style/RedundantInterpolationUnfreeze:
311+
Enabled: true
312+
Style/RedundantLineContinuation:
313+
Enabled: true
314+
Style/RedundantRegexpArgument:
315+
Enabled: true
316+
Style/RedundantRegexpConstructor:
317+
Enabled: true
318+
Style/RedundantSelfAssignmentBranch:
319+
Enabled: true
320+
Style/RedundantStringEscape:
321+
Enabled: true
322+
Style/RescueModifier:
323+
Enabled: false
324+
Style/ReturnNilInPredicateMethodDefinition:
325+
Enabled: true
326+
Style/SafeNavigationChainLength:
327+
Enabled: true
328+
Style/SelectByRegexp:
329+
Enabled: true
330+
Style/SendWithLiteralMethodName:
331+
Enabled: true
332+
Style/SingleLineDoEndBlock:
333+
Enabled: true
334+
Style/SoleNestedConditional:
335+
Enabled: false
336+
Style/StringChars:
337+
Enabled: true
338+
Style/StringLiterals:
339+
EnforcedStyle: double_quotes
340+
Style/SuperArguments:
341+
Enabled: true
342+
Style/SuperWithArgsParentheses:
343+
Enabled: true
344+
Style/SwapValues:
345+
Enabled: true
346+
Style/SymbolArray:
347+
EnforcedStyle: brackets
348+
Style/TrailingCommaInArrayLiteral:
349+
EnforcedStyleForMultiline: comma
350+
Style/TrailingCommaInHashLiteral:
351+
EnforcedStyleForMultiline: comma
352+
Style/WhileUntilModifier:
353+
Enabled: false
354+
Style/WordArray:
355+
EnforcedStyle: brackets
356+
Style/YAMLFileRead:
357+
Enabled: true

Gemfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
1+
# frozen_string_literal: true
2+
13
source "https://rubygems.org"
24
gemspec
35

46
gem "cucumber", "~> 9.2"
5-
gem "google-style", "~> 1.27.1"
67
gem "minitest", "~> 5.25"
78
gem "minitest-focus", "~> 1.4"
89
gem "minitest-rg", "~> 5.3"
910
gem "rack", "~> 3.2"
1011
gem "redcarpet", "~> 3.6" unless ::RUBY_PLATFORM == "java"
12+
gem "rubocop", "~> 1.81"
1113
gem "webrick", "~> 1.9"
1214
gem "yard", "~> 0.9.37"

cloud_events.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ version = ::CloudEvents::VERSION
2121
spec.require_paths = ["lib"]
2222
spec.required_ruby_version = ">= 2.7"
2323

24-
if spec.respond_to? :metadata
24+
if spec.respond_to?(:metadata)
2525
spec.metadata["changelog_uri"] = "https://cloudevents.github.io/sdk-ruby/v#{version}/file.CHANGELOG.html"
2626
spec.metadata["source_code_uri"] = "https://github.com/cloudevents/sdk-ruby"
2727
spec.metadata["bug_tracker_uri"] = "https://github.com/cloudevents/sdk-ruby/issues"

examples/client/Gemfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
1+
# frozen_string_literal: true
2+
13
source "https://rubygems.org"
24
gem "cloud_events", path: "../.."

0 commit comments

Comments
 (0)