chore: Define ReflectionCapabilities interface

Author: mhevery

modules/angular2/src/reflection/reflection.dart

@@ -5,7 +5,7 @@ import 'types.dart';
 export 'reflector.dart';
 import 'package:angular2/src/facade/lang.dart';
 
-class NoReflectionCapabilities {
+class NoReflectionCapabilities implements IReflectionCapabilities {
   Function factory(Type type) {
     throw "Cannot find reflection information on ${stringify(type)}";
   }

modules/angular2/src/reflection/reflection_capabilities.dart

@@ -4,7 +4,7 @@ import 'reflection.dart';
 import 'types.dart';
 import 'dart:mirrors';
 
-class ReflectionCapabilities {
+class ReflectionCapabilities implements IReflectionCapabilities {
   ReflectionCapabilities([metadataReader]) {}
 
   Function factory(Type type) {

modules/angular2/src/reflection/reflection_capabilities.ts

@@ -1,13 +1,13 @@
 import {Type, isPresent, global} from 'angular2/src/facade/lang';
 import {List, ListWrapper} from 'angular2/src/facade/collection';
-import {GetterFn, SetterFn, MethodFn} from './types';
+import {GetterFn, SetterFn, MethodFn, IReflectionCapabilities} from './types';
 
 // HACK: workaround for Traceur behavior.
 // It expects all transpiled modules to contain this marker.
 // TODO: remove this when we no longer use traceur
 export var __esModule = true;
 
-export class ReflectionCapabilities {
+export class ReflectionCapabilities implements IReflectionCapabilities {
   private _reflect: any;
 
   constructor(reflect?: any) { this._reflect = isPresent(reflect) ? reflect : global.Reflect; }
@@ -101,13 +101,15 @@ export class ReflectionCapabilities {
     return [];
   }
 
-  getter(name: string): GetterFn { return new Function('o', 'return o.' + name + ';'); }
+  getter(name: string): GetterFn { return <GetterFn>new Function('o', 'return o.' + name + ';'); }
 
-  setter(name: string): SetterFn { return new Function('o', 'v', 'return o.' + name + ' = v;'); }
+  setter(name: string): SetterFn {
+    return <SetterFn>new Function('o', 'v', 'return o.' + name + ' = v;');
+  }
 
   method(name: string): MethodFn {
     let functionBody = `if (!o.${name}) throw new Error('"${name}" is undefined');
         return o.${name}.apply(o, args);`;
-    return new Function('o', 'args', functionBody);
+    return <MethodFn>new Function('o', 'args', functionBody);
   }
 }

modules/angular2/src/reflection/reflector.ts

@@ -1,7 +1,7 @@
 import {Type, isPresent, stringify, BaseException} from 'angular2/src/facade/lang';
 import {List, ListWrapper, Map, MapWrapper, StringMapWrapper} from 'angular2/src/facade/collection';
-import {SetterFn, GetterFn, MethodFn} from './types';
-export {SetterFn, GetterFn, MethodFn} from './types';
+import {SetterFn, GetterFn, MethodFn, IReflectionCapabilities} from './types';
+export {SetterFn, GetterFn, MethodFn, IReflectionCapabilities} from './types';
 
 // HACK: workaround for Traceur behavior.
 // It expects all transpiled modules to contain this marker.
@@ -13,9 +13,9 @@ export class Reflector {
   _getters: Map<string, GetterFn>;
   _setters: Map<string, SetterFn>;
   _methods: Map<string, MethodFn>;
-  reflectionCapabilities: any;
+  reflectionCapabilities: IReflectionCapabilities;
 
-  constructor(reflectionCapabilities) {
+  constructor(reflectionCapabilities: IReflectionCapabilities) {
     this._typeInfo = MapWrapper.create();
     this._getters = MapWrapper.create();
     this._setters = MapWrapper.create();
@@ -41,7 +41,7 @@ export class Reflector {
     }
   }
 
-  parameters(typeOfFunc): List<any> {
+  parameters(typeOfFunc): List<List<any>> {
     if (MapWrapper.contains(this._typeInfo, typeOfFunc)) {
       return MapWrapper.get(this._typeInfo, typeOfFunc)["parameters"];
     } else {

modules/angular2/src/reflection/types.dart

@@ -3,3 +3,12 @@ library reflection.types;
 typedef SetterFn(Object obj, value);
 typedef GetterFn(Object obj);
 typedef MethodFn(Object obj, List args);
+
+abstract class IReflectionCapabilities {
+  Function factory(Type type);
+  List<Type> parameters(Type type);
+  List annotations(Type type);
+  GetterFn getter(String name);
+  SetterFn setter(String name);
+  MethodFn method(String name);
+}

modules/angular2/src/reflection/types.ts

@@ -1,8 +1,20 @@
+import {Type} from 'angular2/src/facade/lang';
+import {List} from 'angular2/src/facade/collection';
+
 // HACK: workaround for Traceur behavior.
 // It expects all transpiled modules to contain this marker.
 // TODO: remove this when we no longer use traceur
 export var __esModule = true;
 
-export {Function as SetterFn};
-export {Function as GetterFn};
-export {Function as MethodFn};
+export type SetterFn = (any) => void;
+export type GetterFn = () => any;
+export type MethodFn = (any, List) => any;
+
+export interface IReflectionCapabilities {
+  factory(type: Type): Function;
+  parameters(type: Type): List<List<any>>;
+  annotations(type: Type): List<any>;
+  getter(name: string): GetterFn;
+  setter(name: string): SetterFn;
+  method(name: string): MethodFn;
+}