Skip to content

Commit acea8be

Browse files
authored
chore(datafile manager): Fix lint and formatting (optimizely#500)
Summary: Fix lint and formatting in datafile manager package Test plan: Existing tests
1 parent fe3654a commit acea8be

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed

packages/datafile-manager/__test__/nodeDatafileManager.spec.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,10 @@ describe('nodeDatafileManager', () => {
120120
});
121121
manager.start();
122122
expect(makeGetRequestSpy).toBeCalledTimes(1);
123-
expect(makeGetRequestSpy).toBeCalledWith('https://config.optimizely.com/datafiles/auth/1234.json', expect.anything());
123+
expect(makeGetRequestSpy).toBeCalledWith(
124+
'https://config.optimizely.com/datafiles/auth/1234.json',
125+
expect.anything()
126+
);
124127
await manager.stop();
125128
});
126129

@@ -157,7 +160,7 @@ describe('nodeDatafileManager', () => {
157160
});
158161
manager.start();
159162
expect(makeGetRequestSpy).toBeCalledTimes(1);
160-
expect(makeGetRequestSpy).toBeCalledWith(expect.anything(), { 'Authorization': 'Bearer abcdefgh'});
163+
expect(makeGetRequestSpy).toBeCalledWith(expect.anything(), { Authorization: 'Bearer abcdefgh' });
161164
await manager.stop();
162165
});
163166

@@ -173,7 +176,7 @@ describe('nodeDatafileManager', () => {
173176
const manager = new NodeDatafileManager({
174177
sdkKey: '1234',
175178
datafileAccessToken: 'abcdefgh',
176-
urlTemplate: 'https://myawesomeurl/'
179+
urlTemplate: 'https://myawesomeurl/',
177180
});
178181
manager.start();
179182
expect(makeGetRequestSpy).toBeCalledTimes(1);

packages/datafile-manager/src/nodeDatafileManager.ts

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,32 +18,25 @@ import { getLogger } from '@optimizely/js-sdk-logging';
1818
import { makeGetRequest } from './nodeRequest';
1919
import HttpPollingDatafileManager from './httpPollingDatafileManager';
2020
import { Headers, AbortableRequest } from './http';
21-
import {
22-
NodeDatafileManagerConfig,
23-
DatafileManagerConfig,
24-
} from './datafileManager';
25-
import {
26-
DEFAULT_URL_TEMPLATE,
27-
DEFAULT_AUTHENTICATED_URL_TEMPLATE,
28-
} from './config';
21+
import { NodeDatafileManagerConfig, DatafileManagerConfig } from './datafileManager';
22+
import { DEFAULT_URL_TEMPLATE, DEFAULT_AUTHENTICATED_URL_TEMPLATE } from './config';
2923

3024
const logger = getLogger('NodeDatafileManager');
3125

3226
export default class NodeDatafileManager extends HttpPollingDatafileManager {
33-
3427
private accessToken?: string;
3528

3629
constructor(config: NodeDatafileManagerConfig) {
3730
const defaultUrlTemplate = config.datafileAccessToken ? DEFAULT_AUTHENTICATED_URL_TEMPLATE : DEFAULT_URL_TEMPLATE;
3831
super({
39-
... config,
32+
...config,
4033
urlTemplate: config.urlTemplate || defaultUrlTemplate,
4134
});
4235
this.accessToken = config.datafileAccessToken;
4336
}
4437

4538
protected makeGetRequest(reqUrl: string, headers: Headers): AbortableRequest {
46-
let requestHeaders = Object.assign({}, headers);
39+
const requestHeaders = Object.assign({}, headers);
4740
if (this.accessToken) {
4841
logger.debug('Adding Authorization header with Bearer Token');
4942
requestHeaders['Authorization'] = `Bearer ${this.accessToken}`;

0 commit comments

Comments
 (0)