Merge pull request webpack#10837 from webpack/remove/finish-module-graph

remove logic to finish modules in module graph

Author: sokra

lib/Compilation.js

@@ -1521,10 +1521,7 @@ class Compilation {
 
 	finish(callback) {
 		this.logger.time("finish modules");
-		const { moduleGraph, modules } = this;
-		for (const module of modules) {
-			moduleGraph.finishModule(module);
-		}
+		const { modules } = this;
 		this.hooks.finishModules.callAsync(modules, err => {
 			this.logger.timeEnd("finish modules");
 			if (err) return callback(err);

lib/ModuleGraph.js

@@ -994,29 +994,6 @@ class ModuleGraph {
 		return connection !== undefined ? connection.resolvedModule : null;
 	}
 
-	/**
-	 * @param {Module} module a module
-	 * @returns {void}
-	 */
-	finishModule(module) {
-		/*if (module.buildMeta.exportsType === "default") {
-			const exportsInfo = this.getExportsInfo(module);
-			const defaultInfo = exportsInfo.getExportInfo("default");
-			defaultInfo.canMangleProvide = false;
-			defaultInfo.provided = true;
-			defaultInfo.usedName = SKIP_OVER_NAME;
-			if (module.buildMeta.defaultObject) {
-				const innerObject = defaultInfo.createNestedExportsInfo();
-				if (
-					module.buildMeta.defaultObject === "redirect" ||
-					module.buildMeta.defaultObject === "redirect-warn"
-				) {
-					exportsInfo.setRedirectNamedTo(innerObject);
-				}
-			}
-		}*/
-	}
-
 	/**
 	 * @param {Dependency} dependency the dependency to look for a referenced module
 	 * @returns {ModuleGraphConnection | undefined} the connection

types.d.ts

@@ -3683,7 +3683,6 @@ declare class ModuleGraph {
 	): void;
 	addExtraReason(module: Module, explanation: string): void;
 	getResolvedModule(dependency: Dependency): Module;
-	finishModule(module: Module): void;
 	getConnection(dependency: Dependency): ModuleGraphConnection;
 	getModule(dependency: Dependency): Module;
 	getOrigin(dependency: Dependency): Module;