Skip to content

Fix for #3780: Overwrite cursor #3782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vanderlee wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix for #3780: Overwrite cursor #3782

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aec1ba9
Ignore NetBeans project directory
vanderlee Jan 19, 2016
81b16c3
Overwrite cursor
vanderlee Jan 19, 2016
303c95c
Overwrite cursor
vanderlee Jan 19, 2016
3e8d447
Removed a tab
vanderlee Jan 20, 2016
e5d90ac
Change lineendings to LF
vanderlee Jan 20, 2016
e300a52
Change lineendings to LF
vanderlee Jan 20, 2016
3ac377e
Basic bidi overwrite cursor
vanderlee Jan 26, 2016
fcb7d2c
Fix tabs in CSS
vanderlee Jan 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Basic bidi overwrite cursor
  • Loading branch information
@vanderlee
vanderlee committed Jan 26, 2016
commit 3ac377e3f6f175cd20a8787eafd336b3c6bd43db
7 changes: 5 additions & 2 deletions lib/codemirror.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2323,8 +2323,11 @@
var pos = cursorCoords(cm, head, "div", null, null, !cm.options.singleCursorHeightPerLine);
var content = "\u00a0";
if (cm.state.overwrite) {
var next = movePos(cm.doc, head, 1, 0);
content = next ? (getBetween(cm.doc, head, next)[0] || content) : content;
var lineObj = getLine(cm.doc, head.line);
var order = getOrder(lineObj);
var part = getBidiPartAt(order, head.ch);
var next = movePos(cm.doc, head, part % 2 ? -1 : 1, 0);
content = next ? (getBetween(cm.doc, part % 2 ? next : head, part % 2 ? head : next)[0] || content) : content;
}
var cursor = output.appendChild(elt("div", content, "CodeMirror-cursor"));
cursor.style.left = pos.left + "px";
Expand Down