Skip to content

Commit af2ff28

Browse files
Fix assembly registration
1 parent c0a41a5 commit af2ff28

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

src/React.AspNet.Middleware/ReactBuilderExtensions.cs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*
1+
/*
22
* Copyright (c) Facebook, Inc. and its affiliates.
33
*
44
* This source code is licensed under the MIT license found in the
@@ -35,11 +35,13 @@ public static class ReactBuilderExtensions
3535
/// <param name="app">ASP.NET application builder</param>
3636
/// <param name="configure">ReactJS.NET configuration</param>
3737
/// <param name="fileOptions">Options to use for serving files</param>
38+
/// <param name="useNodeEnvironment"></param>
3839
/// <returns>The application builder (for chaining)</returns>
3940
public static IApplicationBuilder UseReact(
4041
this IApplicationBuilder app,
4142
Action<IReactSiteConfiguration> configure,
42-
BabelFileOptions fileOptions = null
43+
BabelFileOptions fileOptions = null,
44+
bool useNodeEnvironment = false
4345
)
4446
{
4547
RegisterAspNetServices(React.AssemblyRegistration.Container, app.ApplicationServices);
@@ -55,6 +57,12 @@ public static IApplicationBuilder UseReact(
5557

5658
configure(ReactSiteConfiguration.Configuration);
5759

60+
if (useNodeEnvironment)
61+
{
62+
TinyIoCContainer.Current.Unregister<IReactEnvironment>();
63+
TinyIoCContainer.Current.Register<IReactEnvironment, ReactWithNodeEnvironment>();
64+
}
65+
5866
// Allow serving of .jsx files
5967
app.UseMiddleware<BabelFileMiddleware>(fileOptions ?? new BabelFileOptions());
6068

src/React.Core/AssemblyRegistration.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public void Register(TinyIoCContainer container)
3737
container.Register<IJavaScriptEngineFactory, JavaScriptEngineFactory>().AsSingleton();
3838
container.Register<IReactIdGenerator, ReactIdGenerator>().AsSingleton();
3939

40-
container.Register<IReactEnvironment, ReactWithNodeEnvironment>().AsPerRequestSingleton();
40+
container.Register<IReactEnvironment, ReactEnvironment>().AsPerRequestSingleton();
4141
}
4242
}
4343
}

src/React.Sample.Webpack.CoreMvc/Startup.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public void Configure(IApplicationBuilder app)
5050
.AddScriptWithoutTransform("~/dist/runtime.js")
5151
.AddScriptWithoutTransform("~/dist/vendor.js")
5252
.AddScriptWithoutTransform("~/dist/components.js");
53-
});
53+
}, useNodeEnvironment: true);
5454

5555
app.UseStaticFiles();
5656

0 commit comments

Comments
 (0)