wip: fix stuff

Author: jsjoeio

src/node/cli.ts

@@ -396,7 +396,7 @@ export const parse = (
     }
 
     // Everything else goes into _.
-    args._.push(arg)
+    // args._.push(arg)
   }
 
   // If a cert was provided a key must also be provided.
@@ -492,7 +492,7 @@ export async function setDefaults(cliArgs: Args, configArgs?: ConfigArgs): Promi
   // disable auth.
   if (args.link) {
     args.host = "localhost"
-    args.port = "0"
+    // args.port = "0"
     args.socket = undefined
     args.cert = undefined
     args.auth = AuthType.None
@@ -652,9 +652,9 @@ export function bindAddrFromArgs(addr: Addr, args: Args): Addr {
   if (process.env.PORT) {
     addr.port = parseInt(process.env.PORT, 10)
   }
-  if (args.port !== undefined) {
-    addr.port = parseInt(args.port, 10)
-  }
+  // if (args.port !== undefined) {
+  //   addr.port = parseInt(args.port, 10)
+  // }
   return addr
 }
 

test/unit/node/cli.test.ts

@@ -410,8 +410,9 @@ describe("cli", () => {
     process.env.VSCODE_IPC_HOOK_CLI = "test"
     expect(await shouldOpenInExistingInstance(args)).toStrictEqual("test")
 
-    args.port = "8081"
-    args._.push("./file")
+    // hello world
+    // args.port = "8081"
+    // args._.push("./file")
     expect(await shouldOpenInExistingInstance(args)).toStrictEqual("test")
   })
 
@@ -422,7 +423,7 @@ describe("cli", () => {
     await fs.writeFile(vscodeIpcPath, "test")
     await expect(shouldOpenInExistingInstance(args)).resolves.toStrictEqual("test")
 
-    args.port = "8081"
+    // args.port = "8081"
     await expect(shouldOpenInExistingInstance(args)).resolves.toStrictEqual("test")
   })
 
@@ -433,14 +434,14 @@ describe("cli", () => {
     await fs.writeFile(vscodeIpcPath, "test")
     expect(await shouldOpenInExistingInstance(args)).toStrictEqual("test")
 
-    args.port = "8081"
+    // args.port = "8081"
     expect(await shouldOpenInExistingInstance(args)).toStrictEqual("test")
   })
 
   it("should use existing if no unrelated flags are set, has positional, and socket is active", async () => {
     expect(await shouldOpenInExistingInstance(args)).toStrictEqual(undefined)
 
-    args._.push("./file")
+    // args._.push("./file")
     expect(await shouldOpenInExistingInstance(args)).toStrictEqual(undefined)
 
     const socketPath = path.join(testDir, "socket")
@@ -458,7 +459,7 @@ describe("cli", () => {
 
     expect(await shouldOpenInExistingInstance(args)).toStrictEqual(socketPath)
 
-    args.port = "8081"
+    // args.port = "8081"
     expect(await shouldOpenInExistingInstance(args)).toStrictEqual(undefined)
   })
 })