Skip to content

Commit 77c9189

Browse files
committed
Add locale flag back
This is valid again now that we have restored display language support.
1 parent 9c7c213 commit 77c9189

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

CHANGELOG.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,11 @@ implementation (#4414).
3232
- Web socket compression has been made the default (when supported). This means
3333
the `--enable` flag will no longer take `permessage-deflate` as an option.
3434
- Extra extension directories have been removed. The `--extra-extensions-dir`
35-
and `--extra-builtin-extensions-dir` will no longer be accepted.
36-
- The `--install-source` and `--locale` flags have been removed.
35+
and `--extra-builtin-extensions-dir` flags will no longer be accepted.
36+
- The `--install-source` flag has been removed.
3737
- The static endpoint can no longer reach outside code-server. However the
3838
vscode-remote-resource endpoint still can.
39-
- OpenVSX has been made the default marketplace. However this means web
40-
extensions like Vim may be broken.
39+
- OpenVSX has been made the default marketplace.
4140
- The last opened folder/workspace is no longer stored separately in the
4241
settings file (we rely on the already-existing query object instead).
4342

src/node/cli.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ export interface UserProvidedArgs {
5757
enable?: string[]
5858
help?: boolean
5959
host?: string
60+
locale?: string
6061
port?: number
6162
json?: boolean
6263
log?: LogLevel
@@ -163,6 +164,7 @@ const options: Options<Required<UserProvidedArgs>> = {
163164
enable: { type: "string[]" },
164165
help: { type: "boolean", short: "h", description: "Show this output." },
165166
json: { type: "boolean" },
167+
locale: { type: "string" }, // The preferred way to set the locale is via the UI.
166168
open: { type: "boolean", description: "Open in browser on startup. Does not work remotely." },
167169

168170
"bind-addr": {

test/unit/node/cli.test.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ describe("parser", () => {
6363
"--verbose",
6464
"2",
6565

66+
["--locale", "ja"],
67+
6668
["--log", "error"],
6769

6870
"--help",
@@ -103,6 +105,7 @@ describe("parser", () => {
103105
help: true,
104106
host: "0.0.0.0",
105107
json: true,
108+
locale: "ja",
106109
log: "error",
107110
open: true,
108111
port: 8081,

0 commit comments

Comments
 (0)