Support native item and section reloads (facebookarchive#3066)

Author: nguyenhuy

AsyncDisplayKit/ASCollectionView.mm

@@ -1729,22 +1729,32 @@ - (void)rangeController:(ASRangeController *)rangeController didUpdateWithChange
 
       __block NSUInteger numberOfUpdates = 0;
       [self _superPerformBatchUpdates:^{
-        for (_ASHierarchyItemChange *change in [changeSet itemChangesOfType:_ASHierarchyChangeTypeDelete]) {
+        for (_ASHierarchyItemChange *change in [changeSet itemChangesOfType:_ASHierarchyChangeTypeReload]) {
+          [super reloadItemsAtIndexPaths:change.indexPaths];
+          numberOfUpdates++;
+        }
+        
+        for (_ASHierarchySectionChange *change in [changeSet sectionChangesOfType:_ASHierarchyChangeTypeReload]) {
+          [super reloadSections:change.indexSet];
+          numberOfUpdates++;
+        }
+        
+        for (_ASHierarchyItemChange *change in [changeSet itemChangesOfType:_ASHierarchyChangeTypeOriginalDelete]) {
           [super deleteItemsAtIndexPaths:change.indexPaths];
           numberOfUpdates++;
         }
 
-        for (_ASHierarchySectionChange *change in [changeSet sectionChangesOfType:_ASHierarchyChangeTypeDelete]) {
+        for (_ASHierarchySectionChange *change in [changeSet sectionChangesOfType:_ASHierarchyChangeTypeOriginalDelete]) {
           [super deleteSections:change.indexSet];
           numberOfUpdates++;
         }
 
-        for (_ASHierarchySectionChange *change in [changeSet sectionChangesOfType:_ASHierarchyChangeTypeInsert]) {
+        for (_ASHierarchySectionChange *change in [changeSet sectionChangesOfType:_ASHierarchyChangeTypeOriginalInsert]) {
           [super insertSections:change.indexSet];
           numberOfUpdates++;
         }
 
-        for (_ASHierarchyItemChange *change in [changeSet itemChangesOfType:_ASHierarchyChangeTypeInsert]) {
+        for (_ASHierarchyItemChange *change in [changeSet itemChangesOfType:_ASHierarchyChangeTypeOriginalInsert]) {
           [super insertItemsAtIndexPaths:change.indexPaths];
           numberOfUpdates++;
         }

AsyncDisplayKit/ASTableView.mm

@@ -1442,7 +1442,39 @@ - (void)rangeController:(ASRangeController *)rangeController didUpdateWithChange
   LOG(@"--- UITableView beginUpdates");
   [super beginUpdates];
 
-  for (_ASHierarchyItemChange *change in [changeSet itemChangesOfType:_ASHierarchyChangeTypeDelete]) {
+  for (_ASHierarchyItemChange *change in [changeSet itemChangesOfType:_ASHierarchyChangeTypeReload]) {
+    NSArray<NSIndexPath *> *indexPaths = change.indexPaths;
+    UITableViewRowAnimation animationOptions = (UITableViewRowAnimation)change.animationOptions;
+    
+    LOG(@"UITableView reloadRows:%ld rows", indexPaths.count);
+    BOOL preventAnimation = animationOptions == UITableViewRowAnimationNone;
+    ASPerformBlockWithoutAnimation(preventAnimation, ^{
+      if (self.test_enableSuperUpdateCallLogging) {
+        NSLog(@"-[super reloadRowsAtIndexPaths]: %@", indexPaths);
+      }
+      [super reloadRowsAtIndexPaths:indexPaths withRowAnimation:animationOptions];
+    });
+    
+    numberOfUpdates++;
+  }
+  
+  for (_ASHierarchySectionChange *change in [changeSet sectionChangesOfType:_ASHierarchyChangeTypeReload]) {
+    NSIndexSet *sectionIndexes = change.indexSet;
+    UITableViewRowAnimation animationOptions = (UITableViewRowAnimation)change.animationOptions;
+    
+    LOG(@"UITableView reloadSections:%@", sectionIndexes);
+    BOOL preventAnimation = (animationOptions == UITableViewRowAnimationNone);
+    ASPerformBlockWithoutAnimation(preventAnimation, ^{
+      if (self.test_enableSuperUpdateCallLogging) {
+        NSLog(@"-[super reloadSections]: %@", sectionIndexes);
+      }
+      [super reloadSections:sectionIndexes withRowAnimation:animationOptions];
+    });
+    
+    numberOfUpdates++;
+  }
+  
+  for (_ASHierarchyItemChange *change in [changeSet itemChangesOfType:_ASHierarchyChangeTypeOriginalDelete]) {
     NSArray<NSIndexPath *> *indexPaths = change.indexPaths;
     UITableViewRowAnimation animationOptions = (UITableViewRowAnimation)change.animationOptions;
 
@@ -1458,7 +1490,7 @@ - (void)rangeController:(ASRangeController *)rangeController didUpdateWithChange
     numberOfUpdates++;
   }
 
-  for (_ASHierarchySectionChange *change in [changeSet sectionChangesOfType:_ASHierarchyChangeTypeDelete]) {
+  for (_ASHierarchySectionChange *change in [changeSet sectionChangesOfType:_ASHierarchyChangeTypeOriginalDelete]) {
     NSIndexSet *sectionIndexes = change.indexSet;
     UITableViewRowAnimation animationOptions = (UITableViewRowAnimation)change.animationOptions;
 
@@ -1474,7 +1506,7 @@ - (void)rangeController:(ASRangeController *)rangeController didUpdateWithChange
     numberOfUpdates++;
   }
 
-  for (_ASHierarchySectionChange *change in [changeSet sectionChangesOfType:_ASHierarchyChangeTypeInsert]) {
+  for (_ASHierarchySectionChange *change in [changeSet sectionChangesOfType:_ASHierarchyChangeTypeOriginalInsert]) {
     NSIndexSet *sectionIndexes = change.indexSet;
     UITableViewRowAnimation animationOptions = (UITableViewRowAnimation)change.animationOptions;
 
@@ -1490,7 +1522,7 @@ - (void)rangeController:(ASRangeController *)rangeController didUpdateWithChange
     numberOfUpdates++;
   }
 
-  for (_ASHierarchyItemChange *change in [changeSet itemChangesOfType:_ASHierarchyChangeTypeInsert]) {
+  for (_ASHierarchyItemChange *change in [changeSet itemChangesOfType:_ASHierarchyChangeTypeOriginalInsert]) {
     NSArray<NSIndexPath *> *indexPaths = change.indexPaths;
     UITableViewRowAnimation animationOptions = (UITableViewRowAnimation)change.animationOptions;
 

AsyncDisplayKit/Details/ASDataController.mm

@@ -512,6 +512,9 @@ - (void)_updateSectionContextsWithChangeSet:(_ASHierarchyChangeSet *)changeSet
     return;
   }
 
+  // TODO if the change set includes solely section reloads that together are equivalent to reloadData (i.e reload the only section),
+  // do a reloadData here as an optimization.
+  
   if (changeSet.includesReloadData) {
     [_sections removeAllObjects];
 
@@ -559,6 +562,9 @@ - (void)_updateElementsWithChangeSet:(_ASHierarchyChangeSet *)changeSet
 
   __weak id<ASTraitEnvironment> environment = [self.environmentDelegate dataControllerEnvironment];
 
+  // TODO if the change set includes solely section reloads that together are equivalent to reloadData (i.e reload the only section),
+  // do a reloadData here as an optimization.
+  
   if (changeSet.includesReloadData) {
     [_elements removeAllObjects];