Skip to content

Commit 4e779ee

Browse files
authored
Need to set defaultImage, not image if we're a network image node. (facebookarchive#3041)
1 parent b616248 commit 4e779ee

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

AsyncDisplayKit/ASImageNode+AnimatedImage.mm

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
#import <AsyncDisplayKit/ASImageNode+AnimatedImagePrivate.h>
2121
#import <AsyncDisplayKit/ASImageProtocols.h>
2222
#import <AsyncDisplayKit/ASInternalHelpers.h>
23+
#import <AsyncDisplayKit/ASNetworkImageNode.h>
2324
#import <AsyncDisplayKit/ASWeakProxy.h>
2425

2526
NSString *const ASAnimatedImageDefaultRunLoopMode = NSRunLoopCommonModes;
@@ -91,6 +92,17 @@ - (void)coverImageCompleted:(UIImage *)coverImage
9192
}
9293

9394
if (setCoverImage) {
95+
[self setCoverImage:coverImage];
96+
}
97+
}
98+
99+
- (void)setCoverImage:(UIImage *)coverImage
100+
{
101+
//If we're a network image node, we want to set the default image so
102+
//that it will correctly be restored if it exits the range.
103+
if ([self isKindOfClass:[ASNetworkImageNode class]]) {
104+
[(ASNetworkImageNode *)self setDefaultImage:coverImage];
105+
} else {
94106
self.image = coverImage;
95107
}
96108
}
@@ -172,7 +184,7 @@ - (void)didEnterVisibleState
172184
[super didEnterVisibleState];
173185

174186
if (self.animatedImage.coverImageReady) {
175-
self.image = self.animatedImage.coverImage;
187+
[self setCoverImage:self.animatedImage.coverImage];
176188
}
177189
[self startAnimating];
178190
}

0 commit comments

Comments
 (0)