Cleaned up code base and added new tests

Author: paquettg

src/PHPHtmlParser/Dom/AbstractNode.php

@@ -44,7 +44,7 @@ abstract class AbstractNode
     /**
      * The unique id of the class. Given by PHP.
      *
-     * @var string
+     * @var int
      */
     protected $id;
 
@@ -55,6 +55,13 @@ abstract class AbstractNode
      */
     protected $encode;
 
+    /**
+     * An array of all the children.
+     *
+     * @var array
+     */
+    protected $children = [];
+
     /**
      * Creates a unique id for this node.
      */
@@ -242,7 +249,8 @@ public function hasNextSibling(): bool
     {
         try
         {
-            $sibling = $this->nextSibling();
+            $this->nextSibling();
+
             // sibling found, return true;
             return true;
         }
@@ -418,7 +426,7 @@ public function ancestorByTag(string $tag): AbstractNode
      *
      * @param string $selector
      * @param int $nth
-     * @return array|AbstractNode
+     * @return mixed
      */
     public function find(string $selector, int $nth = null)
     {

src/PHPHtmlParser/Dom/Collection.php

@@ -28,7 +28,7 @@ class Collection implements IteratorAggregate, ArrayAccess, Countable
      *
      * @param string $method
      * @param array $arguments
-     * @return mixed;
+     * @return mixed
      * @throws EmptyCollectionException
      */
     public function __call(string $method, array $arguments)
@@ -72,7 +72,7 @@ public function __toString(): string
         if ($node instanceof AbstractNode) {
             return (string)$node;
         } else {
-            throw new EmptyCollectionException('The collection does not contain any Nodes.');
+            return '';
         }
     }
 

src/PHPHtmlParser/Options.php

@@ -7,7 +7,12 @@
  * @package PHPHtmlParser
  * @property bool whitespaceTextNode
  * @property bool strict
- * @property bool enforceEncoding
+ * @property string|null enforceEncoding
+ * @property bool cleanupInput
+ * @property bool removeScripts
+ * @property bool removeStyles
+ * @property bool preserveLineBreaks
+ * @property bool removeDoubleSpace
  */
 class Options
 {

tests/CollectionTest.php

@@ -39,6 +39,13 @@ public function testCallNoNodes()
         $collection->innerHtml();
     }
 
+    public function testNoNodeString()
+    {
+        $collection = new Collection();
+        $string = (string) $collection;
+        $this->assertEmpty($string);
+    }
+
     public function testCallMagic()
     {
         $root   = new HtmlNode(new Tag('root'));
@@ -114,4 +121,27 @@ public function testToArray()
         $lastA      = end($array);
         $this->assertEquals($child3->id(), $lastA->id());
     }
+
+    public function testGetIterator()
+    {
+        $collection = new Collection();
+        $iterator = $collection->getIterator();
+        $this->assertTrue($iterator instanceof \ArrayIterator);
+        
+    }
+
+    public function testOffsetSet()
+    {
+        $collection = new Collection();
+        $collection->offsetSet(7, true);
+        $this->assertTrue($collection->offsetGet(7));
+    }
+
+    public function testOffsetUnset()
+    {
+        $collection = new Collection();
+        $collection->offsetSet(7, true);
+        $collection->offsetUnset(7);
+        $this->assertTrue(is_null($collection->offsetGet(7)));
+    }
 }

tests/Node/TextTest.php

@@ -30,7 +30,7 @@ public function testAncestorByTag()
     public function testPreserveEntity()
     {
         $node = new TextNode('i');
-        $text = $node->innerhtml;
+        $text = $node->outerhtml;
         $this->assertEquals('i', $text);
     }