Skip to content

Commit 3718dfd

Browse files
tomekl007KevinGilmore
authored andcommitted
Bael 1010 hll (eugenp#2256)
* BAEL-1010 HLL article code * BAEL-1010 moved tolerated difference to a variable * Merge branch 'master' of https://github.com/eugenp/tutorials into BAEL-1010_hll # Conflicts: # libraries/pom.xml * BAEL-1010 clearer code
1 parent 7df3f24 commit 3718dfd

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

libraries/src/test/java/com/baeldung/hll/HLLUnitTest.java

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ public void givenHLL_whenAddHugeAmountOfNumbers_thenShouldReturnEstimatedCardina
2222

2323
//when
2424
LongStream.range(0, numberOfElements).forEach(element -> {
25-
long hashedValue = hashFunction.newHasher().putLong(element).hash().asLong();
26-
hll.addRaw(hashedValue);
27-
}
25+
long hashedValue = hashFunction.newHasher().putLong(element).hash().asLong();
26+
hll.addRaw(hashedValue);
27+
}
2828
);
2929

3030
//then
@@ -43,21 +43,22 @@ public void givenTwoHLLs_whenAddHugeAmountOfNumbers_thenShouldReturnEstimatedCar
4343

4444
//when
4545
LongStream.range(0, numberOfElements).forEach(element -> {
46-
long hashedValue = hashFunction.newHasher().putLong(element).hash().asLong();
47-
firstHll.addRaw(hashedValue);
48-
}
46+
long hashedValue = hashFunction.newHasher().putLong(element).hash().asLong();
47+
firstHll.addRaw(hashedValue);
48+
}
4949
);
5050

5151
LongStream.range(numberOfElements, numberOfElements * 2).forEach(element -> {
52-
long hashedValue = hashFunction.newHasher().putLong(element).hash().asLong();
53-
secondHLL.addRaw(hashedValue);
54-
}
52+
long hashedValue = hashFunction.newHasher().putLong(element).hash().asLong();
53+
secondHLL.addRaw(hashedValue);
54+
}
5555
);
5656

5757
//then
5858
firstHll.union(secondHLL);
5959
long cardinality = firstHll.cardinality();
60-
assertThat(isSimilarTo(cardinality, numberOfElements * 2, toleratedDifference)).isTrue();
60+
assertThat(isSimilarTo(cardinality, numberOfElements * 2,
61+
toleratedDifference * 2)).isTrue();
6162
}
6263

6364
private boolean isSimilarTo(long cardinality, int numberOfElements, int maxToleratedDifference) {

0 commit comments

Comments
 (0)