BAEL-88 Testing in Spring Boot (eugenp#1679)

Review comments

Author: yasin3061

spring-boot/src/main/java/org/baeldung/boot/boottest/EmployeeRestController.java

@@ -5,26 +5,27 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.PostMapping;
 import org.springframework.web.bind.annotation.RequestBody;
 import org.springframework.web.bind.annotation.RequestMapping;
-import org.springframework.web.bind.annotation.RequestMethod;
 import org.springframework.web.bind.annotation.RestController;
 
 @RestController
 @RequestMapping("/api")
 public class EmployeeRestController {
 
     @Autowired
-    EmployeeService employeeService;
+    private EmployeeService employeeService;
 
-    @RequestMapping(value = "/employees", method = RequestMethod.POST)
+    @PostMapping("/employees")
     public ResponseEntity<Employee> createEmployee(@RequestBody Employee employee) {
         HttpStatus status = HttpStatus.CREATED;
         Employee saved = employeeService.save(employee);
         return new ResponseEntity<>(saved, status);
     }
 
-    @RequestMapping(value = "/employees", method = RequestMethod.GET)
+    @GetMapping("/employees")
     public List<Employee> getAllEmployees() {
         return employeeService.getAllEmployees();
     }

spring-boot/src/main/java/org/baeldung/boot/boottest/EmployeeServiceImpl.java

@@ -13,7 +13,7 @@
 public class EmployeeServiceImpl implements EmployeeService {
 
     @Autowired
-    EmployeeRepository employeeRepository;
+    private EmployeeRepository employeeRepository;
 
     @Override
     public Optional<Employee> getEmployeeById(Long id) {

spring-boot/src/test/java/org/baeldung/boot/boottest/EmployeeRepositoryTest.java

@@ -20,10 +20,10 @@
 public class EmployeeRepositoryTest {
 
     @Autowired
-    TestEntityManager entityManager;
+    private TestEntityManager entityManager;
 
     @Autowired
-    EmployeeRepository employeeRepository;
+    private EmployeeRepository employeeRepository;
 
     @Test
     public void whenFindByName_thenReturnEmployee() {

spring-boot/src/test/java/org/baeldung/boot/boottest/EmployeeRestControllerIntTest.java

@@ -34,10 +34,10 @@
 public class EmployeeRestControllerIntTest {
 
     @Autowired
-    MockMvc mvc;
+    private MockMvc mvc;
 
     @Autowired
-    EmployeeRepository repository;
+    private EmployeeRepository repository;
 
     @After
     public void resetDb() {

spring-boot/src/test/java/org/baeldung/boot/boottest/EmployeeRestControllerTest.java

@@ -33,10 +33,10 @@
 public class EmployeeRestControllerTest {
 
     @Autowired
-    MockMvc mvc;
+    private MockMvc mvc;
 
     @MockBean
-    EmployeeService service;
+    private EmployeeService service;
 
     @Before
     public void setUp() throws Exception {

spring-boot/src/test/java/org/baeldung/boot/boottest/EmployeeServiceImplTest.java

@@ -34,10 +34,10 @@ public EmployeeService employeeService() {
     }
 
     @Autowired
-    EmployeeService employeeService;
+    private EmployeeService employeeService;
 
     @MockBean
-    EmployeeRepository employeeRepository;
+    private EmployeeRepository employeeRepository;
 
     @Before
     public void setUp() {