Fixed Issues based on CodeFactor

Author: codingdefined

src/LetsDisc.Application/MultiTenancy/Dto/CreateTenantDto.cs

@@ -24,6 +24,6 @@ public class CreateTenantDto
         [StringLength(AbpTenantBase.MaxConnectionStringLength)]
         public string ConnectionString { get; set; }
 
-        public bool IsActive {get; set;}
+        public bool IsActive { get; set; }
     }
 }

src/LetsDisc.Application/Posts/PostAppService.cs

@@ -57,7 +57,6 @@ public override async Task<PostDto> Create(CreatePostDto input)
             CheckCreatePermission();
 
             var post = ObjectMapper.Map<Post>(input);
-
             var newPostId = await _postRepository.InsertAndGetIdAsync(post);
 
             await insertTagData(input.Tags, newPostId);
@@ -218,8 +217,7 @@ public async Task<PagedResultDto<PostDto>> GetQuestions(PagedAndSortedResultRequ
                 questions = _postRepository
                                     .GetAll()
                                     .Include(a => a.CreatorUser)
-                                    .Where(a => a.PostTypeId == (int)PostTypes.Question);
-                                    
+                                    .Where(a => a.PostTypeId == (int)PostTypes.Question);                              
             }
 
             switch (input.Sorting)
@@ -380,7 +378,6 @@ public async Task<VoteChangeOutput> PostVoteDown(int id)
 
         public async Task<PostWithVoteInfo> SubmitAnswer(SubmitAnswerInput input)
         {
-
             var answer = await _postRepository.InsertAsync(
                 new Post()
                 {

src/LetsDisc.Web.Core/Controllers/TokenAuthController.cs

@@ -274,7 +274,6 @@ private string GetEncrpyedAccessToken(string accessToken)
         [HttpGet]
         public IActionResult SignInWithExternalProvider(string provider)
         {
-            
             var authenticationProperties = _signInManager.ConfigureExternalAuthenticationProperties(provider, Url.Action(nameof(ExternalLoginCallback), new { p = provider }));
             //await HttpContext.SignOutAsync(IdentityConstants.ExternalScheme);
             return Challenge(authenticationProperties, provider);
@@ -312,7 +311,6 @@ public async Task<ActionResult> ExternalLoginCallback(string p, string returnUrl
                 if (userInDB == null)
                 {
                     userInDB = await RegisterForExternalLogin(claims);
-
                 }
 
                 var claimsIdentity = new ClaimsIdentity(claims, CookieAuthenticationDefaults.AuthenticationScheme);
@@ -383,7 +381,5 @@ public async Task<long> ConfirmEmail(long id, string code)
                 return 0;
             }
         }
-
-
     }
 }

src/LetsDisc.Web.Host/App_Data/Logs/Logs.txt

@@ -27,17 +27,17 @@ export class AppPreBootstrap {
         }).done(result => {
             AppConsts.appBaseUrl = result.appBaseUrl;
             AppConsts.remoteServiceBaseUrl = result.remoteServiceBaseUrl;
-            
+
             callback();
         });
     }
 
     private static getCurrentClockProvider(currentProviderName: string): abp.timing.IClockProvider {
-        if (currentProviderName === "unspecifiedClockProvider") {
+        if (currentProviderName === 'unspecifiedClockProvider') {
             return abp.timing.unspecifiedClockProvider;
         }
 
-        if (currentProviderName === "utcClockProvider") {
+        if (currentProviderName === 'utcClockProvider') {
             return abp.timing.utcClockProvider;
         }
 
@@ -50,7 +50,7 @@ export class AppPreBootstrap {
             method: 'GET',
             headers: {
                 Authorization: 'Bearer ' + abp.auth.getToken(),
-                'AspNetCore.Culture': abp.utils.getCookieValue("Abp.Localization.CultureName"),
+                'AspNetCore.Culture': abp.utils.getCookieValue('Abp.Localization.CultureName'),
                 'Abp.TenantId': abp.multiTenancy.getTenantIdCookie()
             }
         }).done(result => {

src/LetsDisc.Web.Host/App_Data/Logs/Logs.txt.1

@@ -14,6 +14,6 @@ export class AboutComponent extends AppComponentBase {
         private titleService: Title
     ) {
         super(injector);
-        this.titleService.setTitle("About - LetsDisc");
+        this.titleService.setTitle('About - LetsDisc');
     }
-}
+}

src/LetsDisc.Web.Host/src/AppPreBootstrap.ts

@@ -36,5 +36,5 @@ export class AccountComponent extends AppComponentBase {
 
     printError(errorData) {
         console.log(errorData);
-    }  
-}
+    }
+}

src/LetsDisc.Web.Host/src/app/about/about.component.ts

@@ -1,7 +1,13 @@
 
 import { Injectable } from '@angular/core';
 import { Router } from '@angular/router';
-import { TokenAuthServiceProxy, AuthenticateModel, AuthenticateResultModel, ExternalLoginProviderInfoModel, ExternalAuthenticateModel, ExternalAuthenticateResultModel } from '@shared/service-proxies/service-proxies';
+import {
+    TokenAuthServiceProxy,
+    AuthenticateModel,
+    AuthenticateResultModel,
+    ExternalAuthenticateModel,
+    ExternalAuthenticateResultModel
+} from '@shared/service-proxies/service-proxies';
 import { UrlHelper } from '@shared/helpers/UrlHelper';
 import { AppConsts } from '@shared/AppConsts';
 
@@ -68,7 +74,10 @@ export class LoginService {
         this.authenticateResult = authenticateResult;
 
         if (authenticateResult.accessToken) {
-            this.login(authenticateResult.accessToken, authenticateResult.encryptedAccessToken, authenticateResult.expireInSeconds, this.rememberMe);
+            this.login(authenticateResult.accessToken,
+                authenticateResult.encryptedAccessToken,
+                authenticateResult.expireInSeconds,
+                this.rememberMe);
 
         } else {
             this._logService.warn('Unexpected authenticateResult!');
@@ -78,7 +87,7 @@ export class LoginService {
 
     private login(accessToken: string, encryptedAccessToken: string, expireInSeconds: number, rememberMe?: boolean): void {
 
-        var tokenExpireDate = rememberMe ? (new Date(new Date().getTime() + 1000 * expireInSeconds)) : undefined;
+        const tokenExpireDate = rememberMe ? (new Date(new Date().getTime() + 1000 * expireInSeconds)) : undefined;
 
         this._tokenService.setToken(
             accessToken,
@@ -92,7 +101,7 @@ export class LoginService {
             abp.appPath
         );
 
-        var initialUrl = UrlHelper.initialUrl;
+        let initialUrl = UrlHelper.initialUrl;
         if (initialUrl.indexOf('/login') > 0) {
             initialUrl = AppConsts.appBaseUrl;
         }
@@ -106,4 +115,4 @@ export class LoginService {
         this.authenticateResult = null;
         this.rememberMe = false;
     }
-}
+}

src/LetsDisc.Web.Host/src/app/account/account.component.ts

@@ -17,14 +17,14 @@ export class AppComponent extends AppComponentBase implements OnInit, AfterViewI
     }
 
     ngOnInit(): void {
- 
+
         SignalRAspNetCoreHelper.initSignalR();
 
         abp.event.on('abp.notifications.received', userNotification => {
             abp.notifications.showUiNotifyForUserNotification(userNotification);
 
-            //Desktop notification
-            Push.create("AbpZeroTemplate", {
+            // Desktop notification
+            Push.create('AbpZeroTemplate', {
                 body: userNotification.notification.data.message,
                 icon: abp.appPath + 'assets/app-logo-small.png',
                 timeout: 6000,
@@ -43,7 +43,7 @@ export class AppComponent extends AppComponentBase implements OnInit, AfterViewI
 
     onResize(event) {
         // exported from $.AdminBSB.activateAll
-        //$.AdminBSB.leftSideBar.setMenuHeight();
+        // $.AdminBSB.leftSideBar.setMenuHeight();
         $.AdminBSB.leftSideBar.checkStatuForResize(false);
 
         // exported from $.AdminBSB.activateDemo