Remove unused attachment_support field from ChannelType

rowanseymour · rowanseymour · commit a773f1fad985 · 2022-10-31T11:38:02.000-05:00
diff --git a/temba/channels/models.py b/temba/channels/models.py
@@ -77,7 +77,6 @@ class IVRProtocol(Enum):
 
     max_length = -1
     max_tps = None
-    attachment_support = False
     free_sending = False
     quick_reply_text_size = 20
 
@@ -166,12 +165,6 @@ def deactivate_trigger(self, trigger):
         Called when a trigger that is bound to a channel of this type is being released.
         """
 
-    def has_attachment_support(self, channel):
-        """
-        Whether the given channel instance supports message attachments
-        """
-        return self.attachment_support
-
     def get_configuration_context_dict(self, channel):
         return dict(channel=channel, ip_addresses=settings.IP_ADDRESSES)
 
diff --git a/temba/channels/types/africastalking/type.py b/temba/channels/types/africastalking/type.py
@@ -26,7 +26,6 @@ class AfricasTalkingType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 160
-    attachment_support = False
 
     configuration_blurb = _(
         "To finish configuring your Africa's Talking connection you'll need to set the following callback URLs on the "
diff --git a/temba/channels/types/android/type.py b/temba/channels/types/android/type.py
@@ -26,7 +26,6 @@ class AndroidType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = -1
-    attachment_support = False
     free_sending = False
     show_config_page = False
 
diff --git a/temba/channels/types/arabiacell/type.py b/temba/channels/types/arabiacell/type.py
@@ -18,7 +18,6 @@ class ArabiaCellType(ChannelType):
     category = ChannelType.Category.PHONE
     schemes = [URN.TEL_SCHEME]
     max_length = 1530
-    attachment_support = False
 
     claim_view = ClaimView
     claim_blurb = _("If you have an %(link)s number, you can quickly connect it using their APIs.") % {
diff --git a/temba/channels/types/blackmyna/type.py b/temba/channels/types/blackmyna/type.py
@@ -25,7 +25,6 @@ class BlackmynaType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 1600
-    attachment_support = False
 
     configuration_blurb = _(
         "To finish configuring your Blackmyna connection you'll need to notify Blackmyna of the following URLs."
diff --git a/temba/channels/types/bongolive/type.py b/temba/channels/types/bongolive/type.py
@@ -20,7 +20,6 @@ class BongoLiveType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 160
-    attachment_support = False
 
     claim_view = ClaimView
     claim_blurb = _("If you have an %(link)s number, you can quickly connect it using their APIs.") % {
diff --git a/temba/channels/types/burstsms/type.py b/temba/channels/types/burstsms/type.py
@@ -33,7 +33,6 @@ class BurstSMSType(ChannelType):
     category = ChannelType.Category.PHONE
     schemes = [URN.TEL_SCHEME]
     max_length = 613
-    attachment_support = False
 
     claim_view = AuthenticatedExternalClaimView
     claim_view_kwargs = {
diff --git a/temba/channels/types/chikka/type.py b/temba/channels/types/chikka/type.py
@@ -26,7 +26,6 @@ class ChikkaType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 160
-    attachment_support = False
 
     configuration_blurb = _(
         "To finish configuring your Chikka connection you need to set the following URLs in your "
diff --git a/temba/channels/types/clickatell/type.py b/temba/channels/types/clickatell/type.py
@@ -27,7 +27,6 @@ class ClickatellType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 420
-    attachment_support = False
 
     configuration_blurb = _(
         "To finish configuring your Clickatell connection you'll need to set the following callback URLs on the "
diff --git a/temba/channels/types/clickmobile/type.py b/temba/channels/types/clickmobile/type.py
@@ -28,7 +28,6 @@ class ClickMobileType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 459
-    attachment_support = False
 
     configuration_blurb = _(
         "To finish configuring your channel you need to configure Click Mobile to send new messages to the URL below."
diff --git a/temba/channels/types/clicksend/type.py b/temba/channels/types/clicksend/type.py
@@ -58,7 +58,6 @@ class ClickSendType(ChannelType):
     category = ChannelType.Category.PHONE
     schemes = [URN.TEL_SCHEME]
     max_length = 1224
-    attachment_support = False
 
     claim_view = AuthenticatedExternalClaimView
     claim_view_kwargs = {
diff --git a/temba/channels/types/dartmedia/type.py b/temba/channels/types/dartmedia/type.py
@@ -25,7 +25,6 @@ class DartMediaType(ChannelType):
 
     schemes = [URN.TEL_SCHEME, URN.EXTERNAL_SCHEME]
     max_length = 160
-    attachment_support = False
 
     show_public_addresses = True
 
diff --git a/temba/channels/types/dialog360/tests.py b/temba/channels/types/dialog360/tests.py
@@ -60,7 +60,6 @@ def test_claim(self, mock_health):
         self.assertEqual("RW", channel.country)
         self.assertEqual("D3", channel.channel_type)
         self.assertEqual(45, channel.tps)
-        self.assertTrue(channel.type.has_attachment_support(channel))
 
         # test activating the channel
         with patch("requests.post") as mock_post:
diff --git a/temba/channels/types/dialog360/type.py b/temba/channels/types/dialog360/type.py
@@ -37,7 +37,6 @@ class Dialog360Type(ChannelType):
 
     schemes = [URN.WHATSAPP_SCHEME]
     max_length = 4096
-    attachment_support = True
 
     def get_urls(self):
         return [
diff --git a/temba/channels/types/discord/type.py b/temba/channels/types/discord/type.py
@@ -34,7 +34,6 @@ class DiscordType(ChannelType):
 
     schemes = [URN.DISCORD_SCHEME]
     max_length = 1600
-    attachment_support = True
     free_sending = True
 
     redact_response_keys = {"first_name", "last_name", "username"}
diff --git a/temba/channels/types/dmark/type.py b/temba/channels/types/dmark/type.py
@@ -27,7 +27,6 @@ class DMarkType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 459
-    attachment_support = False
 
     configuration_blurb = _(
         "To finish configuring your DMark channel you need to set DMark to send MO messages to the URL below."
diff --git a/temba/channels/types/external/type.py b/temba/channels/types/external/type.py
@@ -25,7 +25,6 @@ class ExternalType(ChannelType):
 
     schemes = None  # can be any scheme
     max_length = 160
-    attachment_support = False
 
     CONFIG_SEND_AUTHORIZATION = "send_authorization"
     CONFIG_MAX_LENGTH = "max_length"
diff --git a/temba/channels/types/facebook/type.py b/temba/channels/types/facebook/type.py
@@ -31,7 +31,6 @@ class FacebookType(ChannelType):
 
     schemes = [URN.FACEBOOK_SCHEME]
     max_length = 320
-    attachment_support = True
     free_sending = True
 
     def deactivate(self, channel):
diff --git a/temba/channels/types/facebookapp/type.py b/temba/channels/types/facebookapp/type.py
@@ -36,7 +36,6 @@ class FacebookAppType(ChannelType):
 
     schemes = [URN.FACEBOOK_SCHEME]
     max_length = 2000
-    attachment_support = True
     free_sending = True
 
     def get_urls(self):
diff --git a/temba/channels/types/firebase/type.py b/temba/channels/types/firebase/type.py
@@ -26,7 +26,6 @@ class FirebaseCloudMessagingType(ChannelType):
 
     schemes = [URN.FCM_SCHEME]
     max_length = 10000
-    attachment_support = False
     free_sending = True
     quick_reply_text_size = 36
 
diff --git a/temba/channels/types/freshchat/type.py b/temba/channels/types/freshchat/type.py
@@ -25,7 +25,6 @@ class FreshChatType(ChannelType):
     claim_view = ClaimView
 
     schemes = [URN.FRESHCHAT_SCHEME]
-    attachment_support = True
     free_sending = True
 
     configuration_blurb = _(
diff --git a/temba/channels/types/globe/type.py b/temba/channels/types/globe/type.py
@@ -26,7 +26,6 @@ class GlobeType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 160
-    attachment_support = False
 
     configuration_blurb = _(
         "To finish configuring your Globe Labs connection you'll need to set the following notify URI for SMS on your "
diff --git a/temba/channels/types/highconnection/type.py b/temba/channels/types/highconnection/type.py
@@ -26,7 +26,6 @@ class HighConnectionType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 1500
-    attachment_support = False
 
     configuration_blurb = _(
         "To finish configuring your connection you'll need to notify HighConnection of the following URL for incoming "
diff --git a/temba/channels/types/hormuud/type.py b/temba/channels/types/hormuud/type.py
@@ -26,7 +26,6 @@ class HormuudType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 160
-    attachment_support = False
 
     configuration_blurb = _(
         "To finish configuring your connection you'll need to notify Hormuud of the following URL for incoming "
diff --git a/temba/channels/types/hub9/type.py b/temba/channels/types/hub9/type.py
@@ -23,7 +23,6 @@ class Hub9Type(ChannelType):
 
     schemes = [URN.TEL_SCHEME, URN.EXTERNAL_SCHEME]
     max_length = 1600
-    attachment_support = False
 
     show_public_addresses = True
 
diff --git a/temba/channels/types/i2sms/type.py b/temba/channels/types/i2sms/type.py
@@ -26,7 +26,6 @@ class I2SMSType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 160
-    attachment_support = False
 
     configuration_blurb = _(
         "To finish configuring your I2SMS channel you'll need to set the message URL for the `DEFAULT` keyword as "
diff --git a/temba/channels/types/infobip/type.py b/temba/channels/types/infobip/type.py
@@ -25,7 +25,6 @@ class InfobipType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 1600
-    attachment_support = False
 
     configuration_blurb = _(
         "To finish configuring your Infobip connection you'll need to set the following callback URLs on the Infobip "
diff --git a/temba/channels/types/instagram/type.py b/temba/channels/types/instagram/type.py
@@ -38,7 +38,6 @@ class InstagramType(ChannelType):
 
     schemes = [URN.INSTAGRAM_SCHEME]
     max_length = 2000
-    attachment_support = True
     free_sending = True
 
     def get_urls(self):
diff --git a/temba/channels/types/jasmin/type.py b/temba/channels/types/jasmin/type.py
@@ -25,7 +25,6 @@ class JasminType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 1600
-    attachment_support = False
 
     configuration_blurb = _(
         "As a last step you'll need to configure Jasmin to call the following URL for MO (incoming) messages."
diff --git a/temba/channels/types/jiochat/type.py b/temba/channels/types/jiochat/type.py
@@ -27,7 +27,6 @@ class JioChatType(ChannelType):
 
     schemes = [URN.JIOCHAT_SCHEME]
     max_length = 1600
-    attachment_support = False
     free_sending = True
 
     configuration_blurb = _(
diff --git a/temba/channels/types/justcall/type.py b/temba/channels/types/justcall/type.py
@@ -23,7 +23,6 @@ class JustCallType(ChannelType):
     category = ChannelType.Category.PHONE
     schemes = [URN.TEL_SCHEME]
     max_length = 160
-    attachment_support = False
 
     claim_view = ClaimView
 
diff --git a/temba/channels/types/kaleyra/type.py b/temba/channels/types/kaleyra/type.py
@@ -28,7 +28,6 @@ class KaleyraType(ChannelType):
 
     schemes = [URN.WHATSAPP_SCHEME]
     max_length = 4096
-    attachment_support = True
 
     configuration_blurb = _(
         "To finish configuring your Kaleyra connection you'll need to set the following callback URL on your Kaleyra "
diff --git a/temba/channels/types/kannel/type.py b/temba/channels/types/kannel/type.py
@@ -27,5 +27,3 @@ class KannelType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 1600
-
-    attachment_support = False
diff --git a/temba/channels/types/line/type.py b/temba/channels/types/line/type.py
@@ -27,7 +27,6 @@ class LineType(ChannelType):
 
     schemes = [URN.LINE_SCHEME]
     max_length = 1600
-    attachment_support = False
     free_sending = True
 
     show_public_addresses = True
diff --git a/temba/channels/types/m3tech/type.py b/temba/channels/types/m3tech/type.py
@@ -25,7 +25,6 @@ class M3TechType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 160
-    attachment_support = False
 
     configuration_blurb = _(
         "To finish configuring your connection you'll need to notify M3Tech of the following callback URLs."
diff --git a/temba/channels/types/macrokiosk/type.py b/temba/channels/types/macrokiosk/type.py
@@ -26,8 +26,6 @@ class MacrokioskType(ChannelType):
     schemes = [URN.TEL_SCHEME]
     max_length = 1600
 
-    attachment_support = False
-
     configuration_blurb = _(
         "To finish configuring your MACROKIOSK connection you'll need to notify MACROKIOSK of the following URLs."
     )
diff --git a/temba/channels/types/mblox/type.py b/temba/channels/types/mblox/type.py
@@ -26,7 +26,6 @@ class MbloxType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 459
-    attachment_support = False
 
     configuration_blurb = _("As a last step you'll need to set the following callback URL on your Mblox account.")
 
diff --git a/temba/channels/types/messangi/type.py b/temba/channels/types/messangi/type.py
@@ -33,8 +33,6 @@ class MessangiType(ChannelType):
     schemes = [URN.TEL_SCHEME]
     max_length = 150
 
-    attachment_support = False
-
     configuration_blurb = _(
         "To finish configuring your Messangi connection you'll need to set the following callback URLs on your Messangi"
         " account."
diff --git a/temba/channels/types/mtarget/type.py b/temba/channels/types/mtarget/type.py
@@ -24,7 +24,6 @@ class MtargetType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 765
-    attachment_support = False
 
     claim_view = ClaimView
     claim_blurb = _("If you have an %(link)s account, you can quickly connect it using their APIs.") % {
diff --git a/temba/channels/types/novo/type.py b/temba/channels/types/novo/type.py
@@ -29,8 +29,6 @@ class NovoType(ChannelType):
     schemes = [URN.TEL_SCHEME]
     max_length = 160
 
-    attachment_support = False
-
     configuration_urls = (
         dict(
             label=_("Receive URL"),
diff --git a/temba/channels/types/playmobile/type.py b/temba/channels/types/playmobile/type.py
@@ -27,8 +27,6 @@ class PlayMobileType(ChannelType):
     schemes = [URN.TEL_SCHEME]
     max_length = 160
 
-    attachment_support = False
-
     configuration_blurb = _(
         "To finish configuring your Play Mobile connection you'll need to notify Play Mobile of the following URL."
     )
diff --git a/temba/channels/types/redrabbit/type.py b/temba/channels/types/redrabbit/type.py
@@ -24,7 +24,6 @@ class RedRabbitType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 1600
-    attachment_support = False
 
     def is_available_to(self, org, user):
         return False, False  # Hidden since it is MT only
diff --git a/temba/channels/types/shaqodoon/type.py b/temba/channels/types/shaqodoon/type.py
@@ -25,7 +25,6 @@ class ShaqodoonType(ChannelType):
 
     schemes = [URN.TEL_SCHEME]
     max_length = 1600
-    attachment_support = False
 
     configuration_blurb = _(
         "To finish configuring your Shaqodoon connection you'll need to provide Shaqodoon with the following delivery "
diff --git a/temba/channels/types/signalwire/type.py b/temba/channels/types/signalwire/type.py
@@ -77,8 +77,6 @@ class SignalWireType(ChannelType):
     schemes = [URN.TEL_SCHEME]
     max_length = 1600
 
-    attachment_support = True
-
     async_activation = False
 
     configuration_blurb = _("Your SignalWire channel is now connected.")
diff --git a/temba/channels/types/smscentral/type.py b/temba/channels/types/smscentral/type.py
@@ -28,8 +28,6 @@ class SMSCentralType(ChannelType):
     max_length = 1600
     max_tps = 1
 
-    attachment_support = False
-
     configuration_blurb = _(
         "To finish configuring your SMSCentral connection you'll need to notify SMSCentral of the following URL."
     )
diff --git a/temba/channels/types/start/type.py b/temba/channels/types/start/type.py
@@ -26,8 +26,6 @@ class StartType(ChannelType):
     schemes = [URN.TEL_SCHEME]
     max_length = 1600
 
-    attachment_support = False
-
     configuration_blurb = _(
         "To finish configuring your Start connection you'll need to notify Start of the following receiving URL."
     )
diff --git a/temba/channels/types/telegram/type.py b/temba/channels/types/telegram/type.py
@@ -31,7 +31,6 @@ class TelegramType(ChannelType):
 
     schemes = [URN.TELEGRAM_SCHEME]
     max_length = 1600
-    attachment_support = True
     free_sending = True
 
     redact_response_keys = {"first_name", "last_name", "username"}
diff --git a/temba/channels/types/telesom/type.py b/temba/channels/types/telesom/type.py
diff --git a/temba/channels/types/thinq/type.py b/temba/channels/types/thinq/type.py
diff --git a/temba/channels/types/twilio_messaging_service/type.py b/temba/channels/types/twilio_messaging_service/type.py
diff --git a/temba/channels/types/twiml_api/type.py b/temba/channels/types/twiml_api/type.py
diff --git a/temba/channels/types/twitter/tests.py b/temba/channels/types/twitter/tests.py
diff --git a/temba/channels/types/twitter/type.py b/temba/channels/types/twitter/type.py
diff --git a/temba/channels/types/viber_public/tests.py b/temba/channels/types/viber_public/tests.py
diff --git a/temba/channels/types/viber_public/type.py b/temba/channels/types/viber_public/type.py
diff --git a/temba/channels/types/vk/type.py b/temba/channels/types/vk/type.py
diff --git a/temba/channels/types/wavy/type.py b/temba/channels/types/wavy/type.py
diff --git a/temba/channels/types/wechat/type.py b/temba/channels/types/wechat/type.py
diff --git a/temba/channels/types/whatsapp/tests.py b/temba/channels/types/whatsapp/tests.py
diff --git a/temba/channels/types/whatsapp/type.py b/temba/channels/types/whatsapp/type.py
diff --git a/temba/channels/types/whatsapp_cloud/tests.py b/temba/channels/types/whatsapp_cloud/tests.py
diff --git a/temba/channels/types/whatsapp_cloud/type.py b/temba/channels/types/whatsapp_cloud/type.py
diff --git a/temba/channels/types/yo/type.py b/temba/channels/types/yo/type.py
diff --git a/temba/channels/types/zenvia/type.py b/temba/channels/types/zenvia/type.py
