Skip to content

Commit b3976f2

Browse files
committed
Disable checkpoint/restore unit tests for docker
Currently, nerdctl CI uses docker 28.0.4, while docker version 28.x has a known regression that breaks Checkpoint/Restore functionality. The issue is tracked in the moby/moby project as moby/moby#50750. Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
1 parent be4d744 commit b3976f2

2 files changed

Lines changed: 10 additions & 0 deletions

File tree

cmd/nerdctl/checkpoint/checkpoint_create_linux_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,11 @@ import (
3030

3131
func TestCheckpointCreateErrors(t *testing.T) {
3232
testCase := nerdtest.Setup()
33+
3334
testCase.Require = require.Not(nerdtest.Rootless)
35+
// Docker version 28.x has a known regression that breaks Checkpoint/Restore functionality.
36+
// The issue is tracked in the moby/moby project as https://github.com/moby/moby/issues/50750.
37+
testCase.Require = require.Not(nerdtest.Docker)
3438
testCase.SubTests = []*test.Case{
3539
{
3640
Description: "too-few-arguments",
@@ -72,6 +76,9 @@ func TestCheckpointCreate(t *testing.T) {
7276
)
7377
testCase := nerdtest.Setup()
7478
testCase.Require = require.Not(nerdtest.Rootless)
79+
// Docker version 28.x has a known regression that breaks Checkpoint/Restore functionality.
80+
// The issue is tracked in the moby/moby project as https://github.com/moby/moby/issues/50750.
81+
testCase.Require = require.Not(nerdtest.Docker)
7582
testCase.SubTests = []*test.Case{
7683
{
7784
Description: "leave-running=true",

cmd/nerdctl/container/container_start_linux_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,9 @@ func TestStartWithCheckpoint(t *testing.T) {
8686
testCase := nerdtest.Setup()
8787
testCase.Require = require.Not(nerdtest.Rootless)
8888

89+
// Docker version 28.x has a known regression that breaks Checkpoint/Restore functionality.
90+
// The issue is tracked in the moby/moby project as https://github.com/moby/moby/issues/50750.
91+
testCase.Require = require.Not(nerdtest.Docker)
8992
testCase.Setup = func(data test.Data, helpers test.Helpers) {
9093
// Start a workload with verifiable state: record continuously increment /tmp/counter
9194
helpers.Ensure("run", "-d", "--name", data.Identifier(), testutil.CommonImage,

0 commit comments

Comments
 (0)