Support legacy push/pull for containerd 1.7.x

Add version detection to automatically select Transfer service (2.0+)
or legacy resolver methods (< 2.0) for better compatibility.

Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>

Author: ChengyuZhu6

pkg/cmd/image/push.go

@@ -43,6 +43,7 @@ import (
 	estargzconvert "github.com/containerd/stargz-snapshotter/nativeconverter/estargz"
 
 	"github.com/containerd/nerdctl/v2/pkg/api/types"
+	"github.com/containerd/nerdctl/v2/pkg/containerdutil"
 	"github.com/containerd/nerdctl/v2/pkg/errutil"
 	"github.com/containerd/nerdctl/v2/pkg/imgutil"
 	nerdconverter "github.com/containerd/nerdctl/v2/pkg/imgutil/converter"
@@ -152,8 +153,21 @@ func Push(ctx context.Context, client *containerd.Client, rawRef string, options
 			return err
 		}
 	} else {
-		if err := imgutil.PushImageWithTransfer(ctx, client, parsedReference, pushRef, ref, options); err != nil {
-			return err
+		// Transfer service is available in containerd 1.7, but full support is only in 2.0+
+		// For containerd 1.7, use the legacy resolver-based push method for better compatibility
+		useTransferAPI := containerdutil.SupportsFullTransferService(ctx, client)
+		if !useTransferAPI {
+			log.G(ctx).Debug("Detected containerd < 2.0, using legacy push method")
+		}
+
+		if useTransferAPI {
+			if err := imgutil.PushImageWithTransfer(ctx, client, parsedReference, pushRef, ref, options); err != nil {
+				return err
+			}
+		} else {
+			if err := pushImageWithLocal(ctx, client, parsedReference, pushRef, ref, options, platMC); err != nil {
+				return err
+			}
 		}
 	}
 

pkg/containerdutil/version.go

@@ -0,0 +1,50 @@
+/*
+   Copyright The containerd Authors.
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+*/
+
+package containerdutil
+
+import (
+	"context"
+	"fmt"
+
+	"github.com/Masterminds/semver/v3"
+
+	containerd "github.com/containerd/containerd/v2/client"
+)
+
+func ServerSemVer(ctx context.Context, client *containerd.Client) (*semver.Version, error) {
+	v, err := client.Version(ctx)
+	if err != nil {
+		return nil, err
+	}
+	sv, err := semver.NewVersion(v.Version)
+	if err != nil {
+		return nil, fmt.Errorf("failed to parse the containerd version %q: %w", v.Version, err)
+	}
+	return sv, nil
+}
+
+// SupportsFullTransferService checks if the containerd version fully supports the Transfer service.
+// While containerd 1.7 has Transfer service, full support is only available in 2.0+.
+func SupportsFullTransferService(ctx context.Context, client *containerd.Client) bool {
+	sv, err := ServerSemVer(ctx, client)
+	if err != nil {
+		// If we can't determine version, assume it's an older version for safety
+		return false
+	}
+	v20, _ := semver.NewVersion("2.0.0")
+	return !sv.LessThan(v20)
+}

pkg/imgutil/imgutil.go

@@ -21,6 +21,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
+	"net/http"
 	"reflect"
 
 	"github.com/opencontainers/image-spec/identity"
@@ -38,6 +39,8 @@ import (
 	"github.com/containerd/platforms"
 
 	"github.com/containerd/nerdctl/v2/pkg/api/types"
+	"github.com/containerd/nerdctl/v2/pkg/containerdutil"
+	"github.com/containerd/nerdctl/v2/pkg/errutil"
 	"github.com/containerd/nerdctl/v2/pkg/healthcheck"
 	"github.com/containerd/nerdctl/v2/pkg/idutil/imagewalker"
 	"github.com/containerd/nerdctl/v2/pkg/imgutil/dockerconfigresolver"
@@ -131,7 +134,49 @@ func EnsureImage(ctx context.Context, client *containerd.Client, rawRef string,
 		return nil, err
 	}
 
-	return PullImageWithTransfer(ctx, client, parsedReference, rawRef, options)
+	// Transfer service is available in containerd 1.7, but full support is only in 2.0+
+	// For containerd 1.7, use the legacy resolver-based pull method for better compatibility
+	useTransferAPI := containerdutil.SupportsFullTransferService(ctx, client)
+	if !useTransferAPI {
+		log.G(ctx).Debug("Detected containerd < 2.0, using legacy pull method")
+	}
+
+	if useTransferAPI {
+		return PullImageWithTransfer(ctx, client, parsedReference, rawRef, options)
+	}
+
+	var dOpts []dockerconfigresolver.Opt
+	if options.GOptions.InsecureRegistry {
+		log.G(ctx).Warnf("skipping verifying HTTPS certs for %q", parsedReference.Domain)
+		dOpts = append(dOpts, dockerconfigresolver.WithSkipVerifyCerts(true))
+	}
+	dOpts = append(dOpts, dockerconfigresolver.WithHostsDirs(options.GOptions.HostsDir))
+	resolver, err := dockerconfigresolver.New(ctx, parsedReference.Domain, dOpts...)
+	if err != nil {
+		return nil, err
+	}
+
+	img, err := PullImage(ctx, client, resolver, parsedReference.String(), options)
+	if err != nil {
+		// In some circumstance (e.g. people just use 80 port to support pure http), the error will contain message like "dial tcp <port>: connection refused".
+		if !errors.Is(err, http.ErrSchemeMismatch) && !errutil.IsErrConnectionRefused(err) {
+			return nil, err
+		}
+		if options.GOptions.InsecureRegistry {
+			log.G(ctx).WithError(err).Warnf("server %q does not seem to support HTTPS, falling back to plain HTTP", parsedReference.Domain)
+			dOpts = append(dOpts, dockerconfigresolver.WithPlainHTTP(true))
+			resolver, err = dockerconfigresolver.New(ctx, parsedReference.Domain, dOpts...)
+			if err != nil {
+				return nil, err
+			}
+			return PullImage(ctx, client, resolver, parsedReference.String(), options)
+		}
+		log.G(ctx).WithError(err).Errorf("server %q does not seem to support HTTPS", parsedReference.Domain)
+		log.G(ctx).Info("Hint: you may want to try --insecure-registry to allow plain HTTP (if you are in a trusted network)")
+		return nil, err
+
+	}
+	return img, nil
 }
 
 // ResolveDigest resolves `rawRef` and returns its descriptor digest.

pkg/infoutil/infoutil.go

@@ -25,7 +25,6 @@ import (
 	"strings"
 	"time"
 
-	"github.com/Masterminds/semver/v3"
 	"github.com/docker/docker/pkg/sysinfo"
 
 	containerd "github.com/containerd/containerd/v2/client"
@@ -146,18 +145,6 @@ func ServerVersion(ctx context.Context, client *containerd.Client) (*dockercompa
 	return v, nil
 }
 
-func ServerSemVer(ctx context.Context, client *containerd.Client) (*semver.Version, error) {
-	v, err := client.Version(ctx)
-	if err != nil {
-		return nil, err
-	}
-	sv, err := semver.NewVersion(v.Version)
-	if err != nil {
-		return nil, fmt.Errorf("failed to parse the containerd version %q: %w", v.Version, err)
-	}
-	return sv, nil
-}
-
 func buildctlVersion() dockercompat.ComponentVersion {
 	buildctlBinary, err := buildkitutil.BuildctlBinary()
 	if err != nil {

pkg/taskutil/taskutil.go

@@ -46,7 +46,7 @@ import (
 
 	"github.com/containerd/nerdctl/v2/pkg/cioutil"
 	"github.com/containerd/nerdctl/v2/pkg/consoleutil"
-	"github.com/containerd/nerdctl/v2/pkg/infoutil"
+	"github.com/containerd/nerdctl/v2/pkg/containerdutil"
 )
 
 // TaskOptions contains options for creating a new task
@@ -201,7 +201,7 @@ func NewTask(ctx context.Context, client *containerd.Client, container container
 	} else {
 		var in io.Reader
 		if opts.IsInteractive {
-			if sv, err := infoutil.ServerSemVer(ctx, client); err != nil {
+			if sv, err := containerdutil.ServerSemVer(ctx, client); err != nil {
 				log.G(ctx).Warn(err)
 			} else if sv.LessThan(semver.MustParse("1.6.0-0")) {
 				log.G(ctx).Warnf("`nerdctl (run|exec) -i` without `-t` expects containerd 1.6 or later, got containerd %v", sv)

pkg/testutil/nerdtest/requirements.go

@@ -33,8 +33,8 @@ import (
 
 	"github.com/containerd/nerdctl/v2/pkg/buildkitutil"
 	"github.com/containerd/nerdctl/v2/pkg/clientutil"
+	"github.com/containerd/nerdctl/v2/pkg/containerdutil"
 	ncdefaults "github.com/containerd/nerdctl/v2/pkg/defaults"
-	"github.com/containerd/nerdctl/v2/pkg/infoutil"
 	"github.com/containerd/nerdctl/v2/pkg/inspecttypes/dockercompat"
 	"github.com/containerd/nerdctl/v2/pkg/netutil"
 	"github.com/containerd/nerdctl/v2/pkg/rootlessutil"
@@ -477,7 +477,7 @@ func ContainerdVersion(v string) *test.Requirement {
 				return false, fmt.Sprintf("failed to create client: %v", err)
 			}
 			defer cancel()
-			if sv, err := infoutil.ServerSemVer(ctx, client); err != nil {
+			if sv, err := containerdutil.ServerSemVer(ctx, client); err != nil {
 				return false, err.Error()
 			} else if sv.LessThan(semver.MustParse(v)) {
 				return false, fmt.Sprintf("`nerdctl commit --compression expects containerd %s or later, got containerd %v", v, sv)