Correction to need help link #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey @mike-north , thanks for your PR. Please adjust the failing test with the added space. When that's done I'll merge this in. Thanks! |
Member
|
@mike-north thx a lot. Sorry it took a bit longer. |
3 tasks
Member
|
This has been released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure that the "need help?" URL is clickable in terminals that auto-linkify when possible
Motivation and Context
In #518 the following message was added to commitlint log messages
Because
)is a legal character in URLs, it ends up being picked up by link-aware editors (i.e., vscode) as a broken link:https://github.com/marionebl/commitlint#what-is-commitlint)
How Has This Been Tested?
Types of changes
Checklist: