Making the code more resilient: if the configuration is messed up (empty string or spaces) or simply doesn’t exist, return the default value (and log the error)

Author: alfasin

src/main/java/com/netflix/simianarmy/basic/BasicConfiguration.java

@@ -17,15 +17,19 @@
  */
 package com.netflix.simianarmy.basic;
 
-import java.util.Properties;
-
 import com.netflix.simianarmy.MonkeyConfiguration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import java.util.Properties;
 
 /**
  * The Class BasicConfiguration.
  */
 public class BasicConfiguration implements MonkeyConfiguration {
 
+    /** The Constant LOGGER. */
+    private static final Logger LOGGER = LoggerFactory.getLogger(BasicConfiguration.class);
+
     /** The properties. */
     private Properties props;
 
@@ -59,7 +63,15 @@ public boolean getBoolOrElse(String property, boolean dflt) {
     @Override
     public double getNumOrElse(String property, double dflt) {
         String val = props.getProperty(property);
-        return val == null ? dflt : Double.parseDouble(val);
+        double result = dflt;
+        if (val != null && !val.isEmpty()) {
+            try {
+                result = Double.parseDouble(val);
+            } catch (NumberFormatException e) {
+                LOGGER.error("failed to parse property: " + property + "; returning default value: " + dflt, e);
+            }
+        }
+        return result;
     }
 
     /** {@inheritDoc} */