Skip to content

Commit 9987ddd

Browse files
author
Bret Ambrose
committed
PS4 build death test fix
1 parent c7a25d3 commit 9987ddd

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

aws-cpp-sdk-s3-encryption-tests/CryptoModulesTest.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ namespace
5252
static size_t const CBC_IV_SIZE_BYTES = 16u;
5353

5454
#ifndef ENABLE_COMMONCRYPTO_ENCRYPTION
55-
#if !defined(NDEBUG) && !defined(GTEST_PSEUDO_WINDOWS)
55+
#if !defined(NDEBUG) && defined(GTEST_HAS_DEATH_TEST)
5656
static const char* const BYTES_SPECIFIER = "bytes=0-10";
5757
static const char* const ASSERTION_FAILED = "Assertion .*";
58-
#endif // !defined(NDEBUG) && !defined(GTEST_PSEUDO_WINDOWS)
58+
#endif // !defined(NDEBUG) && defined(GTEST_HAS_DEATH_TEST)
5959
static const char* const GET_RANGE_SPECIFIER = "bytes=20-40";
6060
static const char* const GET_RANGE_OUTPUT = "ge for encryption and";
6161
static size_t const GCM_TAG_LENGTH = 128u;
@@ -714,7 +714,7 @@ namespace
714714
ASSERT_EQ(kmsClient->m_decryptCalledCount, 1u);
715715
}
716716

717-
#if !defined(NDEBUG) && !defined(GTEST_PSEUDO_WINDOWS)
717+
#if !defined(NDEBUG) && defined(GTEST_HAS_DEATH_TEST)
718718
TEST_F(CryptoModulesTest, StrictAERangeGet)
719719
{
720720
SimpleEncryptionMaterials materials(Aws::Utils::Crypto::SymmetricCipher::GenerateKey());
@@ -829,7 +829,7 @@ namespace
829829
auto getObjectFunction = [&s3Client](Aws::S3::Model::GetObjectRequest getRequest) -> Aws::S3::Model::GetObjectOutcome { return s3Client.GetObject(getRequest); };
830830
ASSERT_DEATH({ decryptionModule->GetObjectSecurely(getRequest, headOutcome.GetResult(), contentCryptoMaterial, getObjectFunction); }, ASSERTION_FAILED);
831831
}
832-
#endif // !defined(NDEBUG) && !defined(GTEST_PSEUDO_WINDOWS)
832+
#endif // !defined(NDEBUG) && defined(GTEST_HAS_DEATH_TEST)
833833
#endif
834834

835835
TEST_F(CryptoModulesTest, RangeParserSuccess)

testing-resources/include/aws/external/gtest.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1755,11 +1755,12 @@ using ::std::tuple_size;
17551755
// Google Test does not support death tests for VC 7.1 and earlier as
17561756
// abort() in a VC 7.1 application compiled as GUI in debug config
17571757
// pops up a dialog window that cannot be suppressed programmatically.
1758-
#if (GTEST_OS_LINUX || GTEST_OS_CYGWIN || GTEST_OS_SOLARIS || \
1758+
#if ((GTEST_OS_LINUX || GTEST_OS_CYGWIN || GTEST_OS_SOLARIS || \
17591759
(GTEST_OS_MAC && !GTEST_OS_IOS) || GTEST_OS_IOS_SIMULATOR || \
1760-
(GTEST_OS_WINDOWS_DESKTOP && _MSC_VER >= 1400 && !defined(GTEST_PSEUDO_WINDOWS)) || \
1760+
(GTEST_OS_WINDOWS_DESKTOP && _MSC_VER >= 1400) || \
17611761
GTEST_OS_WINDOWS_MINGW || GTEST_OS_AIX || GTEST_OS_HPUX || \
1762-
GTEST_OS_OPENBSD || GTEST_OS_QNX)
1762+
GTEST_OS_OPENBSD || GTEST_OS_QNX) && \
1763+
!defined(GTEST_DISABLE_DEATH_TESTS))
17631764
# define GTEST_HAS_DEATH_TEST 1
17641765
# include <vector> // NOLINT
17651766
#endif

0 commit comments

Comments
 (0)