No need for Try::Tiny when checking if fields were returned.

Author: oalders

lib/MetaCPAN/Server/Controller.pm

@@ -8,7 +8,6 @@ use JSON;
 use List::MoreUtils ();
 use Moose::Util     ();
 use Moose;
-use Try::Tiny;
 
 BEGIN { extends 'Catalyst::Controller'; }
 
@@ -81,8 +80,8 @@ sub get : Path('') : Args(1) {
     if ( !defined $file ) {
         $c->detach( '/not_found', ['Not found'] );
     }
-    try { $c->stash( $file->{_source} || $file->{fields} ) }
-        or $c->detach( '/not_found',
+    $c->stash( $file->{_source} || $file->{fields} )
+        || $c->detach( '/not_found',
         ['The requested field(s) could not be found'] );
 }
 

lib/MetaCPAN/Server/Controller/Module.pm

@@ -4,7 +4,6 @@ use strict;
 use warnings;
 
 use Moose;
-use Try::Tiny;
 
 BEGIN { extends 'MetaCPAN::Server::Controller::File' }
 
@@ -16,9 +15,10 @@ sub get : Path('') : Args(1) {
     if ( !defined $file ) {
         $c->detach( '/not_found', [] );
     }
-    try { $c->stash( $file->{_source} || $file->{fields} ) }
-        or $c->detach( '/not_found',
+    $c->stash( $file->{_source} || $file->{fields} )
+        || $c->detach( '/not_found',
         ['The requested field(s) could not be found'] );
 }
 
+__PACKAGE__->meta->make_immutable();
 1;

lib/MetaCPAN/Server/Controller/Release.pm

@@ -4,7 +4,6 @@ use strict;
 use warnings;
 
 use Moose;
-use Try::Tiny;
 
 BEGIN { extends 'MetaCPAN::Server::Controller' }
 
@@ -25,8 +24,8 @@ sub find : Path('') : Args(1) {
     if ( !defined $file ) {
         $c->detach( '/not_found', [] );
     }
-    try { $c->stash( $file->{_source} || $file->{fields} ) }
-        or $c->detach( '/not_found',
+    $c->stash( $file->{_source} || $file->{fields} )
+        || $c->detach( '/not_found',
         ['The requested field(s) could not be found'] );
 }
 
@@ -41,9 +40,10 @@ sub get : Path('') : Args(2) {
     if ( !defined $file ) {
         $c->detach( '/not_found', [] );
     }
-    try { $c->stash( $file->{_source} || $file->{fields} ) }
-        or $c->detach( '/not_found',
+    $c->stash( $file->{_source} || $file->{fields} )
+        || $c->detach( '/not_found',
         ['The requested field(s) could not be found'] );
 }
 
+__PACKAGE__->meta->make_immutable;
 1;