Skip to content
This repository was archived by the owner on Sep 22, 2025. It is now read-only.

Conversation

@nithril
Copy link
Contributor

@nithril nithril commented Oct 7, 2013

No description provided.

@buildhive
Copy link

David Pilato » spring-elasticsearch #32 SUCCESS
This pull request looks good
(what's this?)

@buildhive
Copy link

David Pilato » spring-elasticsearch #33 SUCCESS
This pull request looks good
(what's this?)

@buildhive
Copy link

David Pilato » spring-elasticsearch #34 SUCCESS
This pull request looks good
(what's this?)

@ghost ghost assigned dadoonet Nov 9, 2013
@nithril
Copy link
Contributor Author

nithril commented Nov 9, 2013

Is it ok for you David?

@dadoonet
Copy link
Owner

dadoonet commented Nov 9, 2013

Hey Nicolas,

I need to take time to review it properly.
My first comment after a quick look is about the change in XSD file.
I think we should add a new XSD for version 0.3.0.

What do you think?

I will try to add other comments early next week.

Thanks for the PR!

Best.

@nithril
Copy link
Contributor Author

nithril commented Nov 10, 2013

You right, I have not paid attention to the XSD namespace version

@dadoonet
Copy link
Owner

Merged. Thanks.

@dadoonet dadoonet closed this Nov 18, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants