Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: codelucas/newspaper
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: dailydotdev/newspaper
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 20 commits
  • 8 files changed
  • 6 contributors

Commits on Jun 17, 2021

  1. fix cleaning the wrong top node 

    Before this change, `top_node` was cleaned and then copied to the `clean_top_node`.
I believe this is not the original intent and should be fixed because it creates confusion and there's no way to get the raw `top_node`
    @idoshamun
    idoshamun authored Jun 17, 2021
    Configuration menu
    Copy the full SHA
    7bb0c76 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. add ul and ol to the list of nodes to check

    @idoshamun
    idoshamun authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    e4beb8f View commit details
    Browse the repository at this point in the history

  2. deep copy top node in the output formatter

    @idoshamun
    idoshamun authored Jul 28, 2021
    Configuration menu
    Copy the full SHA
    a626a41 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. add support for section based articles

    @idoshamun
    idoshamun authored Oct 19, 2021
    Configuration menu
    Copy the full SHA
    a5b15ff View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. fix medium heuristic for finding the content node

    @idoshamun
    idoshamun authored Oct 25, 2021
    Configuration menu
    Copy the full SHA
    a737681 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. don't clean the default doc variable instead use clean_doc

    @idoshamun
    idoshamun authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    a169a56 View commit details
    Browse the repository at this point in the history

  2. force medium heuristic on medium articles only

    @idoshamun
    idoshamun authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    c01bdec View commit details
    Browse the repository at this point in the history

  3. fallback to clean doc if it wasn't possible to find top node

    @idoshamun
    idoshamun authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    a4dcbe4 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. add fallback heuristics when can't find top node

    @idoshamun
    idoshamun authored Oct 27, 2021
    Configuration menu
    Copy the full SHA
    7b95eb6 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. allow_redirects config option (#2)

    @vpol
    vpol authored Jul 14, 2022
    Configuration menu
    Copy the full SHA
    0655176 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. feat: allow to ignore certain basename regex (#3) 

    Signed-off-by: Viktor Poluksht <vpoluksht@gmail.com>
    @vpol
    vpol authored Apr 13, 2023
    Configuration menu
    Copy the full SHA
    e149436 View commit details
    Browse the repository at this point in the history

  2. fix: more places where we have to check images 

    Signed-off-by: Viktor Poluksht <vpoluksht@gmail.com>
    @vpol
    vpol authored Apr 13, 2023
    Configuration menu
    Copy the full SHA
    7d34fc9 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. fix: type conversion list -> set 

    Signed-off-by: Viktor Poluksht <vpoluksht@gmail.com>
    @vpol
    vpol committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    b75385a View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. chore: set lxml version to supported (#6)

    @denisb0
    denisb0 authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d25229e View commit details
    Browse the repository at this point in the history

Commits on May 14, 2025

  1. feat: add a fallback to image download fail case (#7)

    @denisb0
    denisb0 authored May 14, 2025
    Configuration menu
    Copy the full SHA
    46fed32 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2025

  1. feat: add final_url property to article 

    final_url stores the actual url used to fetch the html after redirects and meta refresh
    @idoshamun
    idoshamun committed Aug 25, 2025
    Configuration menu
    Copy the full SHA
    bc8fd32 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2025

  1. feat: added verify_ssl_cert option to pass to requests for proxy use

    @vpol
    vpol committed Nov 30, 2025
    Configuration menu
    Copy the full SHA
    e69b5f8 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #9 from dailydotdev/feat_verify_ssl_cert_option 

    feat: added verify_ssl_cert option to pass to requests for proxy use
    @vpol
    vpol authored Nov 30, 2025
    Configuration menu
    Copy the full SHA
    c4af991 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2026

  1. feat: use og:title if title is absent 

    Signed-off-by: Viktor Poluksht <viktor@daily.dev>
    @vpol
    vpol committed Mar 31, 2026
    Configuration menu
    Copy the full SHA
    cfa7b65 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #10 from dailydotdev/feat_og_title 

    feat: use og:title if title is absent
    @vpol
    vpol authored Mar 31, 2026
    Configuration menu
    Copy the full SHA
    4e8b3f4 View commit details
    Browse the repository at this point in the history
Loading