allow http-client re-use in async situation #458
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @nddipiazza do you think you could add a test that passes in the http-client with |
Owner
|
@nddipiazza ping again, did you see my question above? |
Author
|
Yeah. sorry i was pulled off that project so I don't have a moment to put in a unit test. feel free to close this PR. |
|
Hi @dakrone, isn't |
Collaborator
|
This has been fixed in #599. Thank you @nddipiazza and @rborer for your contributions! |
Contributor
|
I also think this PR was created to fix #457, right? |
Collaborator
|
Yep, I think so! Thanks for identifying it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow http-client to be reused when async? = true