feat(svg): add a gradientRatio prop#140
Merged
Merged
Conversation
added 2 commits
March 3, 2019 20:02
Add an interval prop that controls the duration of the interval between two animations. For instance, an interval of `.25` and an animation speed of `2` imply that the animation will take 1.5s to complete, and wait 0.5s before starting again.
Add a gradientRatio prop that controls the width of the gradient relative to the viewbox's own width. For instance, a gradientRatio of `0.5` and a width of `200` imply that the resulting gradient will have a width of 100px.
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 96.92% 96.96% +0.04%
==========================================
Files 9 9
Lines 65 66 +1
Branches 9 9
==========================================
+ Hits 63 64 +1
Partials 2 2
Continue to review full report at Codecov.
|
danilowoz
force-pushed
the
feat-gradient-ratio
branch
from
e26de0c to
8c017e1
Compare
Owner
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #139, so you can ignore the first commit.
Summary
Add a gradientRatio prop that controls the width of the gradient relative to the viewbox's own
width. For instance, a gradientRatio of
0.5and a width of200imply that the resulting gradientwill have a width of 100px.
Any Breaking Changes
None, there already was an implicit gradient ratio of
2which I've set as the default.Checklist