From d73b94e305c4c3599723a2c8aecb6882d225a57c Mon Sep 17 00:00:00 2001 From: Kevin Hu Date: Tue, 8 Jun 2021 13:29:44 -0700 Subject: [PATCH 1/4] Fix MyPy stubs --- metadata-ingestion/setup.py | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/metadata-ingestion/setup.py b/metadata-ingestion/setup.py index f6a6b21f995c65..ce2cc00c5f9ac8 100644 --- a/metadata-ingestion/setup.py +++ b/metadata-ingestion/setup.py @@ -98,9 +98,23 @@ def get_long_description(): "mssql-odbc", } +mypy_stubs = { + "sqlalchemy-stubs", + "types-pkg_resources", + "types-six", + "types-python-dateutil", + "types-requests", + "types-toml", + "types-PyMySQL", + "types-PyYAML", + "types-freezegun", + "types-click==0.1.12", +} + base_dev_requirements = { *base_requirements, *framework_common, + *mypy_stubs, "black>=19.10b0", "coverage>=5.1", "flake8>=3.8.3", @@ -110,7 +124,6 @@ def get_long_description(): "pytest-cov>=2.8.1", "pytest-docker", "tox", - "sqlalchemy-stubs", "deepdiff", "requests-mock", "freezegun", From 183fb70e0adfd3fb1782735b67ce6db29ba7ae62 Mon Sep 17 00:00:00 2001 From: Kevin Hu Date: Tue, 8 Jun 2021 13:34:40 -0700 Subject: [PATCH 2/4] Add click comment --- metadata-ingestion/setup.py | 1 + 1 file changed, 1 insertion(+) diff --git a/metadata-ingestion/setup.py b/metadata-ingestion/setup.py index ce2cc00c5f9ac8..1bd64fc7b478dc 100644 --- a/metadata-ingestion/setup.py +++ b/metadata-ingestion/setup.py @@ -108,6 +108,7 @@ def get_long_description(): "types-PyMySQL", "types-PyYAML", "types-freezegun", + # versions 0.1.13 and 0.1.14 seem to have issues "types-click==0.1.12", } From d0849c8526c37fa61acad71f53d8cc0c8058b80a Mon Sep 17 00:00:00 2001 From: Kevin Hu Date: Tue, 8 Jun 2021 14:35:03 -0700 Subject: [PATCH 3/4] Add dataclasses backport --- metadata-ingestion/setup.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/metadata-ingestion/setup.py b/metadata-ingestion/setup.py index 1bd64fc7b478dc..9be11dcff3c5ad 100644 --- a/metadata-ingestion/setup.py +++ b/metadata-ingestion/setup.py @@ -99,6 +99,8 @@ def get_long_description(): } mypy_stubs = { + # for Python 3.6 support + "dataclasses", "sqlalchemy-stubs", "types-pkg_resources", "types-six", From 48e84c52f657c347dd3c48e6472b04f57b045d85 Mon Sep 17 00:00:00 2001 From: Kevin Hu Date: Tue, 8 Jun 2021 14:51:15 -0700 Subject: [PATCH 4/4] Add types-dataclasses --- metadata-ingestion/setup.py | 1 + 1 file changed, 1 insertion(+) diff --git a/metadata-ingestion/setup.py b/metadata-ingestion/setup.py index 9be11dcff3c5ad..c70025ff596161 100644 --- a/metadata-ingestion/setup.py +++ b/metadata-ingestion/setup.py @@ -101,6 +101,7 @@ def get_long_description(): mypy_stubs = { # for Python 3.6 support "dataclasses", + "types-dataclasses", "sqlalchemy-stubs", "types-pkg_resources", "types-six",