#239 | Fix bug in ReportResource delete method and delete associated widgets

Author: mirkan1

redash/handlers/reports.py

@@ -297,7 +297,9 @@ def delete(self, report_id):
         report = get_object_or_404(Report.get_by_id, report_id)
 
         require_object_delete_permission(report, self.current_user)
-        report.remove()
+        report.remove()        
+        # also delete as a cascade the widgets
+        models.Widget.delete_by_report_id(report_id)
 
         self.record_event({
             "action": "delete",

redash/models/__init__.py

@@ -1250,6 +1250,25 @@ def get_id_from_text(self, text):
             return None
         return text.replace("[turnilo-widget]", "").split("/")[0]
 
+    @classmethod
+    def delete_by_report_id(self, _report_id:str):
+        if isinstance(_report_id, int):
+            _report_id = str(_report_id)
+        for i in self.query.all():
+            report_id = i.get_id_from_text(i.text)
+            if report_id == _report_id:
+                db.session.delete(i)
+        db.session.commit()
+
+    def copy(self, dashboard_id):
+        return {
+            "options": self.options,
+            "width": self.width,
+            "text": self.text,
+            "visualization_id": self.visualization_id,
+            "dashboard_id": dashboard_id,
+        }
+    
     def get_report_id(self):
         return self.get_id_from_text(self.text)